Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linter pipeline for go-grpc app #127

Closed
wants to merge 1 commit into from

Conversation

Vibgitcode27
Copy link

Title:

Add linter pipeline for go-grpc app

Description:

This PR adds a linter pipeline for the new Go gRPC API to the samples-go repository.

Issue it solves:

Closes #2511

Changes:

  • Added linter configuration to the pipeline for Go gRPC API.

Testing:

  • Verified that the linter runs successfully on the codebase.
  • Confirmed that the pipeline triggers on commits and pull requests.

Signed-off-by: Vibhor Phalke <vibgitcode27@gmail.com>
@Vibgitcode27
Copy link
Author

Vibgitcode27 commented Jan 17, 2025

Hey @khareyash05 , I believe this solves the issue. Also there are lint issues in most sample applications. If you want I can resolve them.

Comment on lines 47 to 51
- uses: actions/setup-go@v4
with:
go-version: '1.21'
go-version: "1.21"
cache: false
- name: golangci-lint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for doing this ?

Copy link
Author

@Vibgitcode27 Vibgitcode27 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamsouravjha The difference between '1.21' and "1.21" was automatically introduced by the Go extension I use in my editor. Both notations are valid in YAML, and this change doesn't impact the functionality or behavior of the configuration.

@Vibgitcode27
Copy link
Author

@shivamsouravjha What was wrong with my pr?

@shivamsouravjha
Copy link
Contributor

shivamsouravjha commented Jan 30, 2025

this pr just added a check on the other hand the other prs solved for the repo and insured no liniting errors exist.

@Vibgitcode27
Copy link
Author

@shivamsouravjha Thank you for the response. From what I understand, the issue was only about adding the linter pipeline. The accepted PR does exactly what I did, except for some README changes.

There was a separate issue that required fixing lint errors.

@shivamsouravjha
Copy link
Contributor

shivamsouravjha commented Jan 30, 2025

true, as mentioned here on slack we merge the best version of a pr. The readme update also fixed other future issues thus was merged.

Feel free to pick other open issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: linter pipeline for go-grpc
2 participants