-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add linter pipeline for go-grpc app #127
Conversation
Signed-off-by: Vibhor Phalke <vibgitcode27@gmail.com>
Hey @khareyash05 , I believe this solves the issue. Also there are lint issues in most sample applications. If you want I can resolve them. |
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: '1.21' | ||
go-version: "1.21" | ||
cache: false | ||
- name: golangci-lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for doing this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivamsouravjha The difference between '1.21' and "1.21" was automatically introduced by the Go extension I use in my editor. Both notations are valid in YAML, and this change doesn't impact the functionality or behavior of the configuration.
@shivamsouravjha What was wrong with my pr? |
this pr just added a check on the other hand the other prs solved for the repo and insured no liniting errors exist. |
@shivamsouravjha Thank you for the response. From what I understand, the issue was only about adding the linter pipeline. The accepted PR does exactly what I did, except for some README changes. There was a separate issue that required fixing lint errors. |
true, as mentioned here on slack we merge the best version of a pr. The readme update also fixed other future issues thus was merged. Feel free to pick other open issues. |
Title:
Add linter pipeline for go-grpc app
Description:
This PR adds a linter pipeline for the new Go gRPC API to the
samples-go
repository.Issue it solves:
Closes #2511
Changes:
Testing: