Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linter pipeline for go-grpc app #127

Closed
wants to merge 1 commit into from
Closed

feat: add linter pipeline for go-grpc app #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
cancel-in-progress: true


jobs:
golangci:
name: lint
Expand All @@ -31,6 +30,7 @@ jobs:
- fasthttp-postgres
- gin-mongo
- gin-redis
- go-grpc
- go-jwt
- go-twilio
- graphql-sql
Expand All @@ -41,12 +41,12 @@ jobs:
- S3-Keploy
- sse-svelte
- users-profile

steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.21'
go-version: "1.21"
cache: false
- name: golangci-lint
Comment on lines 47 to 51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for doing this ?

Copy link
Author

@Vibgitcode27 Vibgitcode27 Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamsouravjha The difference between '1.21' and "1.21" was automatically introduced by the Go extension I use in my editor. Both notations are valid in YAML, and this change doesn't impact the functionality or behavior of the configuration.

uses: golangci/golangci-lint-action@v3
Expand All @@ -63,4 +63,4 @@ jobs:
only-new-issues: true

# Optional: The mode to install golangci-lint. It can be 'binary' or 'goinstall'.
install-mode: "goinstall"
install-mode: "goinstall"
Loading