Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rob #727

Closed
wants to merge 17 commits into from
Closed

Rob #727

wants to merge 17 commits into from

Conversation

soma2000-lang
Copy link
Contributor

No description provided.

@jbischof
Copy link
Contributor

jbischof commented Feb 7, 2023

@soma2000-lang please use an informative title and description, including mentioned which Issue is resolved. Thank you!

@abheesht17
Copy link
Collaborator

Hey, @soma2000-lang. It seems like you've made this branch on top of your previous PR's branch (all those "Corrected the epsilon values" commits suggest so) . This might be helpful: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests for general advice on creating branches, PRs, etc.

To solve your issue, I'd recommend doing the following:

  1. Close this PR.
  2. Go to your fork: https://github.com/soma2000-lang/keras-nlp/. Click on Sync Fork --> Update Branch.
  3. Go to your local repo, and run git checkout master, followed by git pull.
  4. Now, run git checkout -b xlm-roberta-masked-lm. Make the necessary changes for adding XLMRobertaMaskedLM.
  5. Push these changes by running the following:
git add .
git commit -m "Add XLMRobertaMaskedLM"
git push -u origin xlm-roberta-masked-lm
  1. Open a PR.

And you are good to go! Once the review comments pour in, and in case you need to make additional changes, just make your changes and run this locally:

git add .
git commit -m "<informative-commit-message>"
git push -u origin xlm-roberta-masked-lm

@soma2000-lang
Copy link
Contributor Author

@abheesht17 sure I do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants