Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick Sequential serialization bug fix for r2.13 #18258

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

nkovela1
Copy link
Contributor

This PR is a fix based on the serialization bug reported by @seanpmorgan.

It fixes the serialization format of Sequential models saved with HDF5 and is important for ensuring backwards compatibility with the serialization format switch in TF 2.13.

@qlzh727
Copy link
Member

qlzh727 commented Jun 26, 2023

FYI, original change in a78f714.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 26, 2023
@qlzh727
Copy link
Member

qlzh727 commented Jun 26, 2023

Will let the test run again for the release branch before merge. Thanks for the quick fix.

@seanpmorgan
Copy link

Will fix tensorflow/tensorflow#61085

@qlzh727
Copy link
Member

qlzh727 commented Jun 27, 2023

@nkovela1, seems that the presubmit test failed, but it was passing on head. Could it be any change that is between the current head and the release branch also need to be cherrypick into the release branch?

To reproduce the test failure, you can checkout the rc branch and this pr and run the blaze test locally.

@qlzh727
Copy link
Member

qlzh727 commented Jun 27, 2023

Tested locally with Neel for this PR. The test error is related caused by a inconsistent version of TF used in the config. We suppose to test the RC build against the tf 2.13 RC version, but the test was using the latest tf-nightly. The delta between them was causing these 4 tests to fail.

We have verified those 4 tests locally, and they are passing with tf.2.13 rc2. Merging this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants