kernelci.cli: add pagination options and helper #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gctucker
force-pushed
the
kci-cli-pagination
branch
2 times, most recently
from
cb81762
to
49a9639
Compare
Add the --page-length / -l and --page-number / -n options for paginated API data. Provide a kernelci.cli.get_pagination() function to convert these arguments into the offset / limit values used with the API as pagination is easier with relative numbers on the command line. Add unit tests accordingly to test this function. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
gctucker
force-pushed
the
kci-cli-pagination
branch
from
49a9639
to
11050a1
Compare
|
I think this PR should also include changes to use |
|
If it's not preventing this PR from being merged then I wouldn't spend more time just to shuffle commits around. I don't think it's related, the |
Okay. So I believe it will be included in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the --page-length / -l and --page-number / -n options for paginated API data. Provide a kernelci.cli.get_pagination() function to convert these arguments into the offset / limit values used with the API as pagination is easier with relative numbers on the command line. Add unit tests accordingly to test this function.