Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernelci.cli.get_api() and update commands #2230

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

gctucker
Copy link
Contributor

@gctucker gctucker commented Dec 7, 2023

Add kernelci.cli.get_api() and .get_api_helper() functions and use then in all the kci subcommands accordingly to remove repeated code.

@gctucker gctucker force-pushed the cli-get-api branch 2 times, most recently from 81f8d27 to 7861f03 Compare December 11, 2023 11:35
Add tests/__init__.py to make it a Python package so that Pylint can
import it, as per the Makefile target which just lists "tests".

Signed-off-by: Guillaume Tucker <gtucker@gtucker.io>
Add kernelci.cli.get_api() and a .get_api_helper() wrapper to
facilitate creating API objects and remove some boilerplate code.

Signed-off-by: Guillaume Tucker <gtucker@gtucker.io>
Update all the kernelci.cli commands to use the new .get_api() and
.get_api_helper() functions to reduce code duplication.

Signed-off-by: Guillaume Tucker <gtucker@gtucker.io>
Copy link
Collaborator

@JenySadadia JenySadadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK.

@JenySadadia JenySadadia added this pull request to the merge queue Dec 11, 2023
Merged via the queue into kernelci:main with commit 5c8526b Dec 11, 2023
4 checks passed
@gctucker gctucker deleted the cli-get-api branch December 12, 2023 08:41
@gctucker gctucker mentioned this pull request Dec 15, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants