Configurable services #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
force-pushed
the
configurable-services
branch
from
32ffed5
to
a968b9b
Compare
|
@wkz: As discussed in our AFK code review, this updated force-push of the PR contains:
Other changes compared to the original PR:
|
troglobit
force-pushed
the
configurable-services
branch
from
a968b9b
to
1b5b335
Compare
|
Fix copy-paste error in factory-config. Locally checked and rechecked this time. |
|
Converted to draft, because we need to discuss the NETCONF wire format for enabled. Right now we have a) either split infix-services.yang in two and standardize on |
This patch drops auto-enable of services we want to be able to control via NETCONF/YANG. SSDP and mDNS/SD enable/disable configure support, using native models, will be included in the same PR and LLDP+SNMP may come later, using std. IEEE/IETF models, they are not critical atm. Fix #118 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Everything (!) potentially shared with other sysrepo plugins/daemons and helper functions (not yet in libite) that can be used by other daemons have been relocated to libsrx. Fix #116 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Fix #115 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Also, for usability, add `name:<SVC>` to each service declaration so they can be located more easily and/or enabled/disabled using the service they provide. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Lost in the big summer merge of 2023 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Lost in the big summer merge of 2023 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The script resides with confd and sets up our system for confd, this should make it easier to rememeber where it's located. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
I'm sorry, I'm just so used to this modus from the previous company. The difference to 'exit', which is available on Cisco IOS, is that it on the top-level config context does not exit/abort to admin-exec but instead stops. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This patch adds support for enabling LLDP using the std IEEE 802.1ab LLDP yang model. An infix-lldp model is as well to reduce the set of available parameters to a bare minimum (enabled), for now. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Monday fixup, audit with @wkz Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
configurable-services
branch
from
8aa1bd6
to
47d0976
Compare
wkz
reviewed
Aug 29, 2023
This first version reliles on netcat (nc), mostly because that's what I could figure out how to run in a netns. A better way would be to have a full SsdpClient that can collect query responses properly and log all devices found. This, however, will do fine for verifying SSDP on/off functionality. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
configurable-services
branch
from
47d0976
to
dc0f3ea
Compare
This test use NETCONF to enable/disable SSDP, it then verifies that the DUT responds to, or does not respond to, SSDP discover messages. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This unfortunately required some restructuring, and as well as extending the run time since we have no way of sending Ethernet frames currently in the test framework (socat would be nice). - Put enable/disable of services before tcpdump start, LLDP lingers ... - Extend run time: 3 -> 20 sec to catch periodic LLDP messages Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Bootstrap and daemon-specific helper scripts, sometimes known as foot guns, should not be in $PATH. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
configurable-services
branch
from
dc0f3ea
to
569ab8d
Compare
See issue #126 for details. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsrxfromconfd(confd: break out srx fns to separate library #116)confdfile hierarchy (confd: flatten directory structure now that statd has moved out #115)factory-configfactory-configThere's also a few other minor fixes and additions I found while cleaning up my working directory after the summer, should not be too much of a surprise, I hope.
As discussed offline, any native SNMP support in Infix is postponed for a future date.