Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License fixes for local packages #124

Merged
merged 4 commits into from
Aug 30, 2023
Merged

License fixes for local packages #124

merged 4 commits into from
Aug 30, 2023

Conversation

troglobit
Copy link
Contributor

Minor cleanup of licenses and packaging for statd + confd.

Note: branch based on configurable-services, PR #119

@troglobit troglobit requested a review from wkz August 29, 2023 09:08
@troglobit
Copy link
Contributor Author

For some reason, one of the jobs fail. I'm restarting it for the second time now ...

... seems to be LLDP not showing up when being enabled. I've considered improving that by adding socat to the Docker container, but we're a bit short for time, for the release, so I put it off for now. What do you think, this particular branch does not affect that part of the code, but builds on configurable-services which is a blocker for the release?

@troglobit troglobit force-pushed the license-fixes branch 3 times, most recently from 6a9044e to 346e839 Compare August 30, 2023 08:06
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Correct license for package is the same as confd and libsrx.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
When running `make legal-info` Buildroot will collect source and
licenses for all packages, which generates a few warnings for our
local packages.  Local packages are skipped.

> The source code for packages that set <PKG>_REDISTRIBUTE = NO will not
> be saved.  Patches that were applied are also saved, along with a file
> named series that lists the patches in the order they were applied.

Hence, setting 'foo_REDISTRIBUTE = NO' disables the warning, which seems
like a good idea to reduce the number of unnecessary questions we might
otherwise get.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit added this to the Infix v23.08 milestone Aug 30, 2023
@wkz wkz merged commit 04e8a87 into main Aug 30, 2023
2 checks passed
@wkz wkz deleted the license-fixes branch August 30, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants