turn off http2 for TLS setups for now (minio#11523)

due to lots of issues with x/net/http2, as
well as the bundled h2_bundle.go in the go
runtime should be avoided for now.

golang/go#23559
golang/go#42534
golang/go#43989
golang/go#33425
golang/go#29246

With collection of such issues present, it
make sense to remove HTTP2 support for now

cmd/http/server.go

@@ -194,7 +194,7 @@ func NewServer(addrs []string, handler http.Handler, getCert certs.GetCertificat
  // TLS hardening
  PreferServerCipherSuites: true,
  MinVersion: tls.VersionTLS12,
- NextProtos: []string{"h2", "http/1.1"},
+ NextProtos: []string{"http/1.1", "h2"},
  }
  tlsConfig.GetCertificate = getCert
  }

cmd/utils.go

@@ -45,7 +45,6 @@ import (
  "github.com/minio/minio/cmd/logger"
  "github.com/minio/minio/pkg/handlers"
  "github.com/minio/minio/pkg/madmin"
- "golang.org/x/net/http2"
 )
 
 const (
@@ -481,9 +480,26 @@ func newInternodeHTTPTransport(tlsConfig *tls.Config, dialTimeout time.Duration)
  DisableCompression: true,
  }
 
- if tlsConfig != nil {
- http2.ConfigureTransport(tr)
- }
+ // https://github.com/golang/go/issues/23559
+ // https://github.com/golang/go/issues/42534
+ // https://github.com/golang/go/issues/43989
+ // https://github.com/golang/go/issues/33425
+ // https://github.com/golang/go/issues/29246
+ // if tlsConfig != nil {
+ // trhttp2, _ := http2.ConfigureTransports(tr)
+ // if trhttp2 != nil {
+ // // ReadIdleTimeout is the timeout after which a health check using ping
+ // // frame will be carried out if no frame is received on the
+ // // connection. 5 minutes is sufficient time for any idle connection.
+ // trhttp2.ReadIdleTimeout = 5 * time.Minute
+ // // PingTimeout is the timeout after which the connection will be closed
+ // // if a response to Ping is not received.
+ // trhttp2.PingTimeout = dialTimeout
+ // // DisableCompression, if true, prevents the Transport from
+ // // requesting compression with an "Accept-Encoding: gzip"
+ // trhttp2.DisableCompression = true
+ // }
+ // }
 
  return func() *http.Transport {
  return tr
@@ -532,9 +548,26 @@ func newCustomHTTPTransport(tlsConfig *tls.Config, dialTimeout time.Duration) fu
  DisableCompression: true,
  }
 
- if tlsConfig != nil {
- http2.ConfigureTransport(tr)
- }
+ // https://github.com/golang/go/issues/23559
+ // https://github.com/golang/go/issues/42534
+ // https://github.com/golang/go/issues/43989
+ // https://github.com/golang/go/issues/33425
+ // https://github.com/golang/go/issues/29246
+ // if tlsConfig != nil {
+ // trhttp2, _ := http2.ConfigureTransports(tr)
+ // if trhttp2 != nil {
+ // // ReadIdleTimeout is the timeout after which a health check using ping
+ // // frame will be carried out if no frame is received on the
+ // // connection. 5 minutes is sufficient time for any idle connection.
+ // trhttp2.ReadIdleTimeout = 5 * time.Minute
+ // // PingTimeout is the timeout after which the connection will be closed
+ // // if a response to Ping is not received.
+ // trhttp2.PingTimeout = dialTimeout
+ // // DisableCompression, if true, prevents the Transport from
+ // // requesting compression with an "Accept-Encoding: gzip"
+ // trhttp2.DisableCompression = true
+ // }
+ // }
 
  return func() *http.Transport {
  return tr