Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make json.loads of Python >=3.6 decode bytes by itself #738

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Jul 7, 2023

Quoting https://docs.python.org/3/library/json.html#json.loads :

Changed in version 3.6: s can now be of type bytes or bytearray.
The input encoding should be UTF-8, UTF-16 or UTF-32.

Quoting https://docs.python.org/3/library/json.html#json.loads :
> Changed in version 3.6: s can now be of type bytes or bytearray.
> The input encoding should be UTF-8, UTF-16 or UTF-32.
@codecov-commenter
Copy link

Codecov Report

Merging #738 (05f61ea) into master (4f70152) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   90.52%   90.63%   +0.11%     
==========================================
  Files          28       28              
  Lines        1794     1794              
  Branches      322      322              
==========================================
+ Hits         1624     1626       +2     
+ Misses        135      133       -2     
  Partials       35       35              
Impacted Files Coverage Δ
vcr/filters.py 94.64% <100.00%> (ø)
vcr/matchers.py 95.34% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hartwork hartwork merged commit 7e11cfc into master Jul 11, 2023
11 checks passed
@jairhenrique jairhenrique deleted the json-loads-py36-plus branch July 11, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants