Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body matcher for chunked requests (fixes #734) #739

Merged
merged 3 commits into from
Jul 23, 2023

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Jul 8, 2023

Fixes #734

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2023

Codecov Report

Merging #739 (e69b10c) into master (4f70152) will decrease coverage by 0.54%.
The diff coverage is 66.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   90.52%   89.98%   -0.54%     
==========================================
  Files          28       28              
  Lines        1794     1838      +44     
  Branches      322      338      +16     
==========================================
+ Hits         1624     1654      +30     
- Misses        135      140       +5     
- Partials       35       44       +9     
Impacted Files Coverage Δ
vcr/matchers.py 84.61% <66.66%> (-10.74%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hartwork hartwork merged commit e7c00a4 into master Jul 23, 2023
11 checks passed
@jairhenrique jairhenrique deleted the issue-734-fix-body-matcher-for-chunked-requests branch July 23, 2023 21:24
@sathieu
Copy link
Contributor

sathieu commented Jul 24, 2023

Thanks @hartwork !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[>=4.3.1] Chunked uploads are broken with urllib3 v2
4 participants