Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query param filter for aiohttp (fixes #517) #740

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Jul 10, 2023

Fixes #517, inspired by #683

@hartwork hartwork added the bug label Jul 10, 2023
@hartwork hartwork changed the title Fix query param filter for aiohttp (fixes #512) Fix query param filter for aiohttp (fixes #517) Jul 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #740 (8ab8e63) into master (4f70152) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   90.52%   90.63%   +0.11%     
==========================================
  Files          28       28              
  Lines        1794     1794              
  Branches      322      268      -54     
==========================================
+ Hits         1624     1626       +2     
+ Misses        135      133       -2     
  Partials       35       35              
Impacted Files Coverage Δ
vcr/stubs/aiohttp_stubs.py 94.40% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hartwork hartwork requested a review from kevin1024 July 15, 2023 23:32
@jairhenrique
Copy link
Collaborator

@hartwork :shipit: 😄

@hartwork hartwork merged commit a045a46 into master Jul 19, 2023
@jairhenrique jairhenrique deleted the issue-512-fix-query-param-filter-for-aiohttp branch July 19, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiohttp stub records the full url in the recorded data regardless of parameter filtering
3 participants