Remove unnecessary dependency on six. #743
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #743 +/- ##
==========================================
- Coverage 90.63% 90.52% -0.12%
==========================================
Files 28 28
Lines 1794 1794
Branches 322 322
==========================================
- Hits 1626 1624 -2
- Misses 133 135 +2
Partials 35 35
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
@charettes thanks for the pull request 👍, the output I see from running pytest -v tests/unit/test_vcr.py::TestVCRClass is unchanged, very nice. There is one tiny formatting issue that running black . would fix and that currently causes the red CI at https://github.com/kevin1024/vcrpy/actions/runs/5563344118/jobs/10164187675?pr=743#step:5:37 . Could you apply the tiny fix this needs for a green CI?
@jairhenrique do you have any concerns about the approach taken by this pull request?
Remove the last remaining usag of it in VCR.testcase.
|
@hartwork sure thing, thanks for the review! Just forced-pushed a commit that addresses the formatting issue. |
There was a problem hiding this comment.
@hartwork sure thing, thanks for the review! Just forced-pushed a commit that addresses the formatting issue.
@charettes perfect, thank you! 👍
Remove the last remaining usage of it in VCR.testcase.