test #7
Closed
test #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size Fix long-running loop
…erflow Fix integer overflow which enables enforce to be bypassed
printLensSpecification is copied from old Nikon3MakerNote::print0x0084 call of Nikon3MakerNote::print0x0084 replaced by printLensSpecification add two lens tags to EasyAccess API Exif.Photo.LensSpecification and Exif.Nikon3.Lens handling of zero; more precision for focal length silence compiler warnings
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
…ps://github.com/norbertwg/exiv2 into interpretation-for-Exif.Photo.LensSpecification
…Photo.LensSpecification Interpretation for Exif.Photo.LensSpecification
Fix dllexport/import mismatch. Fixes MSVC/MinGW warnings. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
meson updates
github CI: update conan
…ointer-deref Check that the pointer isn't NULL
More efficient Signed-off-by: Rosen Penev <rosenp@gmail.com>
add various moves
Minor refactorings to stop UBSAN from complaining
Potentially more warnings Signed-off-by: Rosen Penev <rosenp@gmail.com>
sys headers must come before libprocstat meson is missing a libprocstat dependency. iconv is also broken with meson and freebsd. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
The OutputTagExtract test case for tiff_test runs exiv2 two times, with "-pa" and "-pS", and parses their outputs. To know which output to parse, it checks for "-pa" and "-pS" in the string of the command being run; considering that the command string contains the full path to the test data, which is a subdirectory of the sources, this means that a wrong parser will be used in case the full source path contains any of "-pa" or "-pS" (e.g. "/build/some-path/exiv2/..."). Cheap fix for this: since "-pa"/"-pS" are options in the command string, check for them using spaces around. (cherry picked from commit 5f4ffdd)
(cherry picked from commit bcb75b6)
(cherry picked from commit 4232888) # Conflicts: # src/canonmn_int.cpp
(cherry picked from commit f551534)
Signed-off-by: Rosen Penev <rosenp@gmail.com> (cherry picked from commit 3f08319)
Commit a8c3455 and commit eb05551 changed the target of the exiv2 library ("exiv2lib"), exporting it in the "Exiv2" namespace, so making it usable as "Exiv2::exiv2lib" instead. An ALIAS to "exiv2lib" was added, however cmake does not install or export ALIAS targets [1]. Hence, restore compatibility with the existing cmake users of exiv2: manually create an ALIAS target in the cmake config files after all the targets are loaded and checked. [1] https://cmake.org/cmake/help/latest/command/add_library.html (cherry picked from commit 130064d)
The first 5 bytes of the CanonLe block give the serial number when converted to hexadecimal. This PR also fixes bug 2138 as it stops the 30 byte length of the block being truncated to a multiple of 4 bytes. Signed-off-by: Jim Easterbrook <jim@jim-easterbrook.me.uk>
All of them have all-zero serial numbers, so they aren't testing this PR directly. Signed-off-by: Jim Easterbrook <jim@jim-easterbrook.me.uk>
Signed-off-by: Jim Easterbrook <jim@jim-easterbrook.me.uk>
Signed-off-by: Jim Easterbrook <jim@jim-easterbrook.me.uk>
This is what has been causing corruption in my file writing by reducing the block from 30 bytes to 28, offsetting subsequent data by two bytes. Signed-off-by: Jim Easterbrook <jim@jim-easterbrook.me.uk>
(cherry picked from commit 4b3ce1d) # Conflicts: # src/canonmn_int.cpp
(cherry picked from commit 724b7f8) # Conflicts: # src/canonmn_int.cpp
(cherry picked from commit 349c1f2)
(cherry picked from commit 71bb2b1)
(cherry picked from commit 9391c12)
(cherry picked from commit 1290548)
(cherry picked from commit 52d4451)
(cherry picked from commit 7713372)
(cherry picked from commit ac6687b)
(cherry picked from commit 501770a)
(cherry picked from commit e163ead)
Signed-off-by: Rosen Penev <rosenp@gmail.com> (cherry picked from commit 2d7814b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.