Add Python formatting CMake targets (black, flake8) #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CMake targets for running black and flake8 on Python source files CMake will look to find the relevant binaries and setup the targets if they are there If they are not found a STATUS message is printed Targets are excluded from "all" to avoid running them by accident
Actually use the binary that CMake found, rather than searching PATH again
tmadlener
reviewed
Jan 31, 2024
Avoid reformatting things which are the results of a build or install in subdirectories Use PROJECT_SOURCE_DIR for the flake8 configuration file
|
I just realized that we have neither a flake8 nor a black configuration yet for EDM4hep. If it's OK with you, I would simply add them with this PR (and also apply the necessary style fixes). |
|
Superseded by #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMake targets for running black and flake8 on Python source files
CMake will look to find the relevant binaries and setup the targets if they are there, if they are not found a STATUS message is printed
Targets are excluded from "all" to avoid running them by accident
BEGINRELEASENOTES
Add CMake targets for running black and flake8 on Python source files
ENDRELEASENOTES
This is basically the same PR as AIDASoft/podio#544