Add Python formatting targets (black, flake8) #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Jan 23, 2024
2 tasks
Thanks for the suggestions! |
|
I think the CI test failure has nothing to do with this PR, right? |
|
Once this PR is deemed to be in good shape, I will replicate it for https://github.com/key4hep/EDM4hep. |
No, it looks like ROOT has changed something in the RNTuple interface. Specifically, I think it's this PR: root-project/root#14391 Edit: keeping track of this in #545 |
This adds a target for black and flake8, which must be available in the build environment
In this case issue a warning and do not set the target
Downgrade the message when formatter binaries are missign to STATUS Exclude the formatting targets from "all"
Actually use the binary that CMake found, rather than searching PATH again
tmadlener
force-pushed
the
black-target
branch
from
02cdda5 to
f4e5578
Compare
tmadlener
approved these changes
Jan 30, 2024
tmadlener
reviewed
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMake targets for running black and flake8 on Python source files
CMake will look to find the relevant binaries and setup the targets if they are there
If they are not found it's a warning (too severe?)
Note that current Key4hep nightlies don't have flake8 - if we use another linter that can be substituted
BEGINRELEASENOTES
Add CMake targets for running black and flake8 on Python source files
ENDRELEASENOTES