[ntuple] Refactor RNTupleWriter into RNTupleFillContext #14391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
hahnjo
commented
Jan 19, 2024
Test Results 9 files 9 suites 1d 19h 5m 5s ⏱️ For more details on these failures, see this check. Results for commit c415866. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Jan 19, 2024
A context is responsible for preparing a cluster, and will be the unit of parallelisation for concurrent writing.
This is not used yet (RNTupleWriter directly observes the sink's metrics to avoid an extra prefix), but will be useful for parallel writing with multiple contexts.
hahnjo
force-pushed
the
ntuple-FillContext
branch
from
a080c9d to
c415866
Compare
|
Starting build on |
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A context is responsible for preparing a cluster, and will be the unit of parallelisation for concurrent writing. Also has a commit to return
constreference fromRNTupleWriter::GetModel().