Make the event number 64 bits and unsigned #398
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks backwards compatibility for RNTuple as that does not have the necessary schema evolution support to do this on the fly (at least for RC2 of RNTuple). |
|
But I guess it's quite unlikely someone has RNTuples files and a file with event headers at the same time. So recreate the RNTuple file for version 0.99 with a 64 bit event number? It will be unreadable by EDM4hep 0.99, but is that even going to happen? |
Yes that is also what I would do. We should also go to the release RNTuple format there, i.e. ROOT >= 6.34, I think. |
Likely to run into issues with the range of 32 bit integers and the exepected event numbers. LHC is going beyond 32 bit range already in long runs.
jmcarcell
force-pushed
the
event-number-u64
branch
from
459ff94 to
8fd8cc6
Compare
jmcarcell
reviewed
Jan 24, 2025
edm4hep.yaml
Outdated
| @@ -222,7 +222,7 @@ datatypes: | |||
| Description: "Event Header. Additional parameters are assumed to go into the metadata tree." | |||
| Author: "EDM4hep authors" | |||
| Members: | |||
| - int32_t eventNumber // event number | |||
| - uint64_t eventNumber // event number | |||
| - int32_t runNumber // run number | |||
There was a problem hiding this comment.
Maybe the run number should be uint32_t?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
EventHeader::eventNumbera 64 bit unsigned integer to avoid issues with the range of 32 bit integers.ENDRELEASENOTES
This is another small fix that came out of the discussion with HepMC folks (and their experience from LHC). We are likely to run into issues with the range of 32 bit integers and the exepected event numbers. LHC is going beyond 32 bit range already in long runs.