Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the event number 64 bits and unsigned #398

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions edm4hep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,8 @@ datatypes:
Description: "Event Header. Additional parameters are assumed to go into the metadata tree."
Author: "EDM4hep authors"
Members:
- int32_t eventNumber // event number
- int32_t runNumber // run number
- uint64_t eventNumber // event number
- uint32_t runNumber // run number
- uint64_t timeStamp // time stamp
- double weight // event weight
VectorMembers:
Expand Down
9 changes: 4 additions & 5 deletions test/backwards_compat/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@ set_tests_properties(
)


if (ROOT_VERSION VERSION_LESS 6.33)
# This input file has been written with RNTuple RC2 which is only present up
# to the 6.32 release series. Trying to read this with a newer version of ROOT
# doesn't work
if (${ROOT_VERSION} VERSION_GREATER_EQUAL 6.34)
# This input file has been written with ROOT 6.34.
# Trying to read this with an older version of ROOT doesn't work
ExternalData_Add_Test(backward_compat_tests
NAME backwards_compat_rntuple_v00-99 COMMAND pytest -v --inputfile=DATA{${CMAKE_CURRENT_SOURCE_DIR}/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-01.root})
NAME backwards_compat_rntuple_v00-99 COMMAND pytest -v --inputfile=DATA{${CMAKE_CURRENT_SOURCE_DIR}/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-02.root})
set_test_env(backwards_compat_rntuple_v00-99)

set_tests_properties(
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ac7cf308fdec1685f968750429e4d243
Loading