favorites: allow some non-true disable env var values

Suggested by jzila. Issue: #1862
keybase · Oct 22, 2018 · e0057e6 · e0057e6
1 parent f8c96e0
commit e0057e6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/libkbfs/favorites.go b/libkbfs/favorites.go
@@ -6,6 +6,7 @@ package libkbfs
 
 import (
 	"os"
+	"strings"
 	"sync"
 
 	"github.com/keybase/client/go/protocol/keybase1"
@@ -76,8 +77,9 @@ type Favorites struct {
 }
 
 func newFavoritesWithChan(config Config, reqChan chan *favReq) *Favorites {
-	disableVal := os.Getenv(disableFavoritesEnvVar)
-	if len(disableVal) > 0 {
+	disableVal := strings.ToLower(os.Getenv(disableFavoritesEnvVar))
+	if len(disableVal) > 0 && disableVal != "0" && disableVal != "false" &&
+		disableVal != "no" {
 		config.MakeLogger("").CDebugf(nil,
 			"Disable favorites due to env var %s=%s",
 			disableFavoritesEnvVar, disableVal)