Detached pgp verify was broken for messages shorter than 100 bytes #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,7 @@ func (p *StreamPeeker) Peek(buf []byte) (n int, err error) { | |||
| return 0, ErrCannotPeek | |||
| } | |||
| n, err = io.ReadFull(p.r, buf) | |||
| p.buf = append(p.buf, buf...) | |||
| p.buf = append(p.buf, buf[:n]...) | |||
There was a problem hiding this comment.
This was copying all 100 bytes of buf even if the message was shorter, and then those extra bytes were being included in the hash
zanderz
changed the title
| doVerify(t, msg) | ||
| } | ||
|
|
||
| func TestPGPVerifyShortMsg(t *testing.T) { |
There was a problem hiding this comment.
I verified this new test failed before the included changes
zanderz
force-pushed
the
zanderz/CORE-2267
branch
from
54bcc31 to
305748c
Compare
zanderz
pushed a commit
that referenced
this pull request
Feb 2, 2016
Detached pgp verify was broken for messages shorter than 100 bytes
jzila
pushed a commit
that referenced
this pull request
Jan 5, 2019
Suggested by jzila. Issue: #1862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://keybase.atlassian.net/browse/CORE-2267
C:\Program Files\Keybase>keybase pgp verify -d sig1.txt -i msg1.txtERROR unexpected EOF@maxtaco @oconnor663