Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent contact_ip needs to allow hostnames #848

Closed
tuminoid opened this issue Oct 8, 2024 · 0 comments · Fixed by #866
Closed

Agent contact_ip needs to allow hostnames #848

tuminoid opened this issue Oct 8, 2024 · 0 comments · Fixed by #866

Comments

@tuminoid
Copy link

tuminoid commented Oct 8, 2024

Use-case

Keylime agent is in k8s cluster, but Verifier/Tenant/Registrar is outside k8s cluster. Traffic from Verifier to Agent goes via k8s Ingress, which needs to map URL to correct Agent per UUID. Agent is hence reachable at https://agent-<uuid>.cluster.local/ ...

Issue

There is parse_ip called to parse the contact_ip here:

let contact_ip = parse_ip(config.agent.contact_ip.as_ref())?.to_string();
so Agent cannot set hostname such as agent-<uuid>.cluster.local as its contact_ip, meaning it cannot register itself with an address that can be routed back.

xref: https://cloud-native.slack.com/archives/C01ARE2QUTZ/p1727792733885549
@maugustosilva @mheese

ansasaki added a commit to ansasaki/rust-keylime that referenced this issue Nov 12, 2024
For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname
to be used instead of an IP address.

Fixes keylime#848

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
ansasaki added a commit to ansasaki/rust-keylime that referenced this issue Nov 13, 2024
For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname
to be used instead of an IP address.

Fixes keylime#848

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
ansasaki added a commit to ansasaki/rust-keylime that referenced this issue Dec 2, 2024
For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname
to be used instead of an IP address.

Fixes keylime#848

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
ansasaki added a commit to ansasaki/rust-keylime that referenced this issue Dec 2, 2024
For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname
to be used instead of an IP address.

Fixes keylime#848

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant