Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Enable passing a hostname instead of IP #866

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ansasaki
Copy link
Contributor

For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname to be used instead of an IP address.

Fixes #848

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.96%. Comparing base (2f7b3ad) to head (26311dd).
Report is 71 commits behind head on master.

Files with missing lines Patch % Lines
keylime-agent/src/main.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.96% <60.00%> (+1.37%) ⬆️
upstream-unit-tests 58.96% <60.00%> (+7.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime-agent/src/config.rs 77.23% <100.00%> (-10.27%) ⬇️
keylime-agent/src/main.rs 21.22% <0.00%> (-4.80%) ⬇️

... and 9 files with indirect coverage changes

Copy link
Member

@THS-on THS-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname
to be used instead of an IP address.

Fixes keylime#848

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
@ansasaki ansasaki merged commit 351ef6f into keylime:master Dec 2, 2024
9 of 10 checks passed
@ansasaki ansasaki deleted the enable_hostname branch December 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent contact_ip needs to allow hostnames
4 participants