Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(windows): remove WM_KEYMANDEBUG_ messages #10050

Closed
mcdurdin opened this issue Nov 22, 2023 · 0 comments · Fixed by #10055
Closed

chore(windows): remove WM_KEYMANDEBUG_ messages #10050

mcdurdin opened this issue Nov 22, 2023 · 0 comments · Fixed by #10055
Labels
chore windows/
Milestone
A17S26

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Nov 22, 2023 •
edited
Loading

keyman/windows/src/engine/keyman32/appint/aiTIP.cpp

Lines 240 to 244 in db76e25

WM_KEYMANDEBUG_CANDEBUG = RegisterWindowMessage("WM_KEYMANDEBUG_CANDEBUG");
WM_KEYMANDEBUG_GETUNICODESTATUS = RegisterWindowMessage("WM_KEYMANDEBUG_GETUNICODESTATUS");
WM_KEYMANDEBUG_GETCONTEXT = RegisterWindowMessage("WM_KEYMANDEBUG_GETCONTEXT");
WM_KEYMANDEBUG_ACTION = RegisterWindowMessage("WM_KEYMANDEBUG_ACTION");
WM_KEYMANDEBUG_RULEMATCH = RegisterWindowMessage("WM_KEYMANDEBUG_RULEMATCH");

These are never used any more; removal may allow removal of some correlated functions e.g. AITIP::FillStoreOffsets

Identified while preparing for #10052.
This was referenced Nov 22, 2023
Closed
Merged
mcdurdin added a commit that referenced this issue Nov 23, 2023
@mcdurdin
chore(windows): remove wm_keymandebug messages and functions
ee1f972 
Fixes #10050.

Removes the following unused identifiers:
* ::wm_kmdebug
* ::wm_keymandebug
* AppInt::DebugControlled()
* AITIP::WM_KEYMANDEBUG_CANDEBUG
* AITIP::WM_KEYMANDEBUG_GETUNICODESTATUS
* AITIP::WM_KEYMANDEBUG_GETCONTEXT
* AITIP::WM_KEYMANDEBUG_ACTION
* AITIP::WM_KEYMANDEBUG_RULEMATCH
* AITIP::DebugControlled()
* AITIP::IsDebugControlWindow()
* AITIP::GetDebugControlWindow()
* AITIP::Debug_FillContextBuffer()
* AIDEBUGINFO struct
* ::FillStoreOffsets()
* AIDEBUGKEYINFO struct

Removes overloads which are now no-ops:
* AITIP::HandleWindow()
* AITIP::IsWindowHandled()
* AITIP::QueueAction()
@mcdurdin mcdurdin mentioned this issue Nov 23, 2023
Closed
3 tasks
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S26 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore windows/
Projects
None yet
Milestone
A17S26
Development

Successfully merging a pull request may close this issue.

chore(windows): remove wm_keymandebug messages and functions keymanapp/keyman
1 participant
@mcdurdin