Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(windows): remove wm_keymandebug messages and functions #10055

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mcdurdin
Copy link
Member

Fixes #10050.

Removes the following unused identifiers:

  • ::wm_kmdebug
  • ::wm_keymandebug
  • AppInt::DebugControlled()
  • AITIP::WM_KEYMANDEBUG_CANDEBUG
  • AITIP::WM_KEYMANDEBUG_GETUNICODESTATUS
  • AITIP::WM_KEYMANDEBUG_GETCONTEXT
  • AITIP::WM_KEYMANDEBUG_ACTION
  • AITIP::WM_KEYMANDEBUG_RULEMATCH
  • AITIP::DebugControlled()
  • AITIP::IsDebugControlWindow()
  • AITIP::GetDebugControlWindow()
  • AITIP::Debug_FillContextBuffer()
  • AIDEBUGINFO struct
  • ::FillStoreOffsets()
  • AIDEBUGKEYINFO struct

Removes overloads which are now no-ops:

  • AITIP::HandleWindow()
  • AITIP::IsWindowHandled()
  • AITIP::QueueAction()

@keymanapp-test-bot skip

Fixes #10050.

Removes the following unused identifiers:
* ::wm_kmdebug
* ::wm_keymandebug
* AppInt::DebugControlled()
* AITIP::WM_KEYMANDEBUG_CANDEBUG
* AITIP::WM_KEYMANDEBUG_GETUNICODESTATUS
* AITIP::WM_KEYMANDEBUG_GETCONTEXT
* AITIP::WM_KEYMANDEBUG_ACTION
* AITIP::WM_KEYMANDEBUG_RULEMATCH
* AITIP::DebugControlled()
* AITIP::IsDebugControlWindow()
* AITIP::GetDebugControlWindow()
* AITIP::Debug_FillContextBuffer()
* AIDEBUGINFO struct
* ::FillStoreOffsets()
* AIDEBUGKEYINFO struct

Removes overloads which are now no-ops:
* AITIP::HandleWindow()
* AITIP::IsWindowHandled()
* AITIP::QueueAction()
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 23, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit 5c6fbcc into master Nov 23, 2023
7 checks passed
@mcdurdin mcdurdin deleted the chore/windows/remove-wm_keymandebug-messages branch November 23, 2023 01:20
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.216-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(windows): remove WM_KEYMANDEBUG_ messages
3 participants