Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): if normalization=false, do no normalization in kmc ldml compiler #10554

Closed
mcdurdin opened this issue Jan 30, 2024 · 0 comments · Fixed by #10586
Closed

feat(developer): if normalization=false, do no normalization in kmc ldml compiler #10554

mcdurdin opened this issue Jan 30, 2024 · 0 comments · Fixed by #10586
Assignees
@srl295
Labels
developer/ feat
Milestone
B17S1

Comments

@mcdurdin
Copy link
Member

Relates to #10317.
Extracted from #10468.
@mcdurdin mcdurdin added this to the A17S31 milestone Jan 30, 2024
srl295 added a commit that referenced this issue Feb 1, 2024
@srl295
feat(core,developer): normalization=disabled 🙀
9120bb4 
- failing tests and initial work

#10554
srl295 added a commit that referenced this issue Feb 1, 2024
@srl295
feat(developer): support normalization=disabled 🙀
d77ed90 
#10554
@srl295 srl295 mentioned this issue Feb 1, 2024
Merged
@mcdurdin mcdurdin linked a pull request Feb 1, 2024 that will close this issue
feat(core,developer): support normalization=disabled 🙀 #10586
Merged
srl295 added a commit that referenced this issue Feb 1, 2024
@srl295
feat(developer): support normalization=disabled 🙀
eaeb3e4 
- additional test changes
- turn off cooking the 'from' if disabled

#10554
srl295 added a commit that referenced this issue Feb 1, 2024
@srl295
feat(developer): support normalization=disabled 🙀
7572c94 
- main core changes and test changes

#10554
srl295 added a commit that referenced this issue Feb 2, 2024
@srl295
feat(developer): support normalization=disabled 🙀
3a538c1 
- test and code fixes

#10554
srl295 added a commit that referenced this issue Feb 2, 2024
@srl295
feat(developer): support normalization=disabled 🙀
7144383 
- avoid dead store to transforms class

#10554
@mcdurdin mcdurdin modified the milestones: A17S31, B17S1 Feb 3, 2024
@srl295 srl295 mentioned this issue Feb 6, 2024
Open
srl295 added a commit that referenced this issue Feb 6, 2024
@srl295
feat(developer): support normalization=disabled 🙀
50e0b31 
- fix check normalization state

#10554
srl295 added a commit that referenced this issue Feb 6, 2024
@srl295
feat(core): support normalization=disabled 🙀
15b7a42 
- clean up process_output:  remove some unnecessary steps,
refactor into 3 functions, clarify
- reorder functions for ldml_state
- remove extraneous assert() clutter when the normalization
functions already assert/DebugLog at the innermost level

#10554
srl295 added a commit that referenced this issue Feb 6, 2024
@srl295
feat(developer): support normalization=disabled 🙀
9085a4f 
- assume normalization is enabled

#10554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
developer/ feat
Projects
None yet
Milestone
B17S1
Development

Successfully merging a pull request may close this issue.

feat(core,developer): support normalization=disabled 🙀 keymanapp/keyman
2 participants
@srl295 @mcdurdin