fix(web): fixes OSK viewport scaling on iOS devices #10035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Nov 21, 2023
|
Changes in this pull request will be available for download in Keyman version 17.0.215-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened upon this one via Safari's "All Exceptions" breakpoint while investigating something else.
There's a broken
thisref ingetViewportScalethat was introduced by the modularization work. The method was originally part of the oldkmwutilscode (representing thekeyman.utilobject) as seen in this commit of #8808.This would only have been noticeable on iOS devices, and only on 17.0 alpha.
I then noticed that the method was essentially duplicated within the app/browser target, so I DRYed it out upon noticing - it's a pretty simple
exportandimport.@keymanapp-test-bot skip