Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fixes OSK viewport scaling on iOS devices #10035

Merged
merged 2 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/app/browser/src/languageMenu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ export class LanguageMenu {
if(device.OS == 'ios') {
if(device.formFactor == 'phone') {
barWidth=(landscapeView() ? 36 : 0);
maxHeight=(window.innerHeight-barWidth-16)*util.getViewportScale();
maxHeight=(window.innerHeight-barWidth-16)*util.getViewportScale(device.formFactor);
} else if(device.formFactor == 'tablet') {
barWidth=(landscapeView() ? 16 : 0);
maxHeight=(maxHeight-barWidth);
Expand Down Expand Up @@ -316,7 +316,7 @@ export class LanguageMenu {
langs.sort();

// Get current scale factor (reciprocal of viewport scale)
var scale=Math.round(100/util.getViewportScale())/100;
var scale=Math.round(100/util.getViewportScale(device.formFactor))/100;

var dx,lgBar,i,kb,activeLanguageIndex=-1;
for(k=0; k<langs.length; k++) {
Expand Down
42 changes: 0 additions & 42 deletions web/src/app/browser/src/utils/getViewportScale.ts

This file was deleted.

2 changes: 1 addition & 1 deletion web/src/app/browser/src/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export { AlertHost } from './alertHost.js';
export { _CreateElement } from './createElement.js';
export { getStyleValue } from './getStyleValue.js';
export { getViewportScale } from './getViewportScale.js';
export { getViewportScale } from 'keyman/engine/osk';
export { whenDocumentReady } from './documentReady.js';
2 changes: 2 additions & 0 deletions web/src/engine/osk/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export { type OSKKeySpec } from './keyboard-layout/oskKey.js';
export { type default as InputEventCoordinate } from './input/inputEventCoordinate.js';
export { type default as EmbeddedGestureConfig } from './config/embeddedGestureConfig.js';

export { getViewportScale } from './screenUtils.js';

export { default as Activator, StaticActivator } from './views/activator.js';
export { default as SimpleActivator } from './views/simpleActivator.js';
export { default as TwoStateActivator } from './views/twoStateActivator.js';
Expand Down
5 changes: 3 additions & 2 deletions web/src/engine/osk/src/screenUtils.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
import { landscapeView } from "keyman/engine/dom-utils";
import { DeviceSpec } from "@keymanapp/web-utils";

/**
* Get viewport scale factor for this document
*
* @return {number}
*/
export function getViewportScale(): number {
export function getViewportScale(formFactor: DeviceSpec.FormFactor): number {
// This can sometimes fail with some browsers if called before document defined,
// so catch the exception
try {
// For emulation of iOS on a desktop device, use a default value
if(this.device.formFactor == 'desktop') {
if(formFactor == 'desktop') {
return 1;
}

Expand Down
2 changes: 1 addition & 1 deletion web/src/engine/osk/src/views/anchoredOskView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export default class AnchoredOSKView extends OSKView {

// Correct for viewport scaling (iOS - Android 4.2 does not want this, at least on Galaxy Tab 3))
if(this.targetDevice.OS == DeviceSpec.OperatingSystem.iOS) {
height=height/getViewportScale();
height=height/getViewportScale(this.targetDevice.formFactor);
}

return height;
Expand Down
2 changes: 1 addition & 1 deletion web/src/engine/osk/src/views/floatingOskView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ export default class FloatingOSKView extends OSKView {

// Correct for viewport scaling (iOS - Android 4.2 does not want this, at least on Galaxy Tab 3))
if(this.targetDevice.OS == DeviceSpec.OperatingSystem.iOS) {
height=height/getViewportScale();
height=height/getViewportScale(this.targetDevice.formFactor);
}

return height;
Expand Down
2 changes: 1 addition & 1 deletion web/src/engine/osk/src/visualKeyboard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1395,7 +1395,7 @@ export default class VisualKeyboard extends EventEmitter<EventMap> implements Ke
var fs = 1.0;
// TODO: Logically, this should be needed for Android, too - may need to be changed for the next version!
if (device.OS == DeviceSpec.OperatingSystem.iOS && !this.isEmbedded) {
fs = fs / getViewportScale();
fs = fs / getViewportScale(this.device.formFactor);
}

let paddedHeight: number;
Expand Down