Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(android): Document using gestures on touch, and remove references to Browser #10686

Merged
merged 6 commits into from
Feb 15, 2024
Merged

docs(android): Document using gestures on touch, and remove references to Browser #10686

merged 6 commits into from
Feb 15, 2024

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Feb 12, 2024 •
edited
Loading

First of a few small PRs in updating the Keyman for Android in-app help documentation.

Changes to the in-app documentation:

@keymanapp-test-bot skip

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Feb 12, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 12, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S1 milestone Feb 12, 2024
@darcywong00 darcywong00 added this to the B17S1 milestone Feb 12, 2024
rc-swag
rc-swag approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Feb 12, 2024
@jahorton
Copy link
Contributor

jahorton commented Feb 12, 2024 •
edited
Loading

I do not believe that this sufficiently fixes #10627.

See notes I've placed on #10628; we probably want something on a similar level on both platforms, though I suppose there is room for discussion.

The tweak about the longpress hint indicating some gesture is supported, rather than a specific one, probably makes a good jumping off point - a good link-text to lead to a more specialized page.

@mcdurdin
Copy link
Member

I do not believe that this sufficiently fixes #10627.

I concur that we could do with more detail on flicks, although given the detail reqs were in #10628, that's perhaps not a surprise!

I have also added some notes to #10628 which are applicable.

@github-actions github-actions bot added docs and removed docs labels Feb 12, 2024
@darcywong00
Copy link
Contributor Author

I've added a separate page about gesture per your suggestions

#10628 (comment)

I also agree about avoiding the term "modipress" since it's not in the LDML spec. (Maybe we use modifer-press?)

@darcywong00 darcywong00 mentioned this pull request Feb 13, 2024
Merged
@github-actions github-actions bot added docs and removed docs labels Feb 14, 2024
@darcywong00 darcywong00 changed the base branch from master to beta February 15, 2024 03:05
@github-actions github-actions bot added docs and removed docs labels Feb 15, 2024
@github-actions github-actions bot added docs and removed docs labels Feb 15, 2024
@darcywong00
Copy link
Contributor Author

Gesture documentation updated to match 17.0 release notes
https://github.com/keymanapp/keyman/wiki/Keyman-17.0-Release-Notes#using-gestures-on-the-touch-layout-keys

@darcywong00 darcywong00 merged commit 4e40102 into beta Feb 15, 2024
5 checks passed
@darcywong00 darcywong00 deleted the docs/android/flick branch February 15, 2024 06:33
@darcywong00 darcywong00 mentioned this pull request Feb 15, 2024
Closed
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.269-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rc-swag rc-swag rc-swag approved these changes

@sgschantz sgschantz Awaiting requested review from sgschantz

Assignees
No one assigned
Labels
android/ docs
Projects
None yet
Milestone
B17S1
Development

Successfully merging this pull request may close these issues.

docs(android): using new gestures
5 participants
@darcywong00 @jahorton @mcdurdin @keyman-server @rc-swag