-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates dependencies so that vulnerabilities are no longer present. #77
Conversation
@Unitech Would you mind to review / merge this? The latest matching |
@Unitech I'm sorry to bother you. Are you alive? It would be great if you could review this PR so that this vulnerability can be fixed. |
hi. we installed pm2 package in our koa service lately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I do not think this PR will build, (browserify) I am struggling with alarm for this one as well, I think this repo is dead, try to figure out my self. |
I fixed it not building, thanks for letting me know. Tests are still broken though. There's a workaround for anyone who really needs this vulnerability fixed. If you put the following into your project's package.json (depending on your package manager), you should be fine! NPM: "overrides": {
"axios": "^1.6.5"
} PNPM: "pnpm": {
"overrides": {
"axios": "^1.6.5"
}
} Yarn: "resolutions": {
"axios": "^1.6.5"
} @Unitech How do these recent commits look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How about updating the axios to 1.6.5 ??
Done! |
This may need additional testing, as I was unable to test it. However, I looked through the code and saw that all of the uses of axios seem to remain unchanged through the updated versions. If your environment is setup to test, please test this code before merging and suggest any changes that may need to be made!
Fixes #76