Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dependencies so that vulnerabilities are no longer present. #77

Merged
merged 6 commits into from
Jan 20, 2024
Merged

Conversation

OIRNOIR
Copy link
Contributor

@OIRNOIR OIRNOIR commented Nov 12, 2023

This may need additional testing, as I was unable to test it. However, I looked through the code and saw that all of the uses of axios seem to remain unchanged through the updated versions. If your environment is setup to test, please test this code before merging and suggest any changes that may need to be made!

Fixes #76

@buffcode
Copy link

@Unitech Would you mind to review / merge this? The latest matching axios version (0.21.4) was released Sep 6, 2021.

@OIRNOIR
Copy link
Contributor Author

OIRNOIR commented Dec 5, 2023

@Unitech I'm sorry to bother you. Are you alive? It would be great if you could review this PR so that this vulnerability can be fixed.

@humanscape-chan
Copy link

humanscape-chan commented Dec 11, 2023

hi. we installed pm2 package in our koa service lately.
our service's current version of axios is 1.6.2
I'm not sure it's related with axios version, but pm2's option --watct is not working in our product environment.
except that, pm2 with axios 1.6.0 version is working well.

Copy link

@guizzo guizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adilatilgan
Copy link

I do not think this PR will build, (browserify) I am struggling with alarm for this one as well, I think this repo is dead, try to figure out my self.

@OIRNOIR
Copy link
Contributor Author

OIRNOIR commented Dec 29, 2023

I do not think this PR will build, (browserify) I am struggling with alarm for this one as well, I think this repo is dead, try to figure out my self.

I fixed it not building, thanks for letting me know. Tests are still broken though.

There's a workaround for anyone who really needs this vulnerability fixed. If you put the following into your project's package.json (depending on your package manager), you should be fine!

NPM:

"overrides": {
	"axios": "^1.6.5"
}

PNPM:

"pnpm": {
	"overrides": {
		"axios": "^1.6.5"
	}
}

Yarn:

"resolutions": {
	"axios": "^1.6.5"
}

@Unitech How do these recent commits look?

Copy link

@mrhammadasif mrhammadasif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
How about updating the axios to 1.6.5 ??

@OIRNOIR
Copy link
Contributor Author

OIRNOIR commented Jan 10, 2024

LGTM How about updating the axios to 1.6.5 ??

Done!

@Unitech Unitech merged commit b7f2f25 into keymetrics:master Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderate security vulnerability for versions of Axios 0.8.1 - 1.5.1 (Dependency)
7 participants