Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code quality improvements, manually and with clang-tidy/clang-format #310

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

red-robby
Copy link
Contributor

These changes are minimal and include:

  • Marking members functions as const/noexcept if appropriate.
  • Using the standard types from <cstdint> (and prepending all such types with std::).
  • Removing constructors that just initialized member variables. Instead, we initialize them where they are declared.
  • Replacing some constants expressed as macros with equivalent (type safe) constexpr values.

No code logic has been modified.

@red-robby red-robby requested a review from dayeol January 31, 2023 09:52
@red-robby red-robby self-assigned this Jan 31, 2023
@red-robby red-robby changed the title Add basic code quality improvements to SDK/host Add code quality improvements, manually and with clang-tidy/clang-format Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant