Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code quality improvements, manually and with clang-tidy/clang-format #310

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add code quality improvements, manually and with clang-tidy/clang-format #310

wants to merge 16 commits into from

Commits on Jan 31, 2023

  1. Params.hpp -- swap macros with constexpr values; add <cstdint>; use s… 

    …td:: for all standard types; remove unneeded constructor
    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c196d4c View commit details
    Browse the repository at this point in the history

  2. Params.hpp -- add const/noexcept to member functions as appropriate

    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    339ca74 View commit details
    Browse the repository at this point in the history

  3. ElfFile.hpp/.cpp -- add std:: to standard types; add const/noexcept a… 

    …s appropriate
    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    df8dd86 View commit details
    Browse the repository at this point in the history

  4. ElfFile.cpp -- add std:: to standard types (missed before)

    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    22e9bcd View commit details
    Browse the repository at this point in the history

  5. Enclave.hpp/.cpp -- similar improvements

    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    bf2a205 View commit details
    Browse the repository at this point in the history

  6. Enclave.hpp -- reorder includes

    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0828080 View commit details
    Browse the repository at this point in the history

  7. KeystoneDevice.hpp/.cpp -- similar improvements

    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    033bf35 View commit details
    Browse the repository at this point in the history

  8. Memory.cpp/.hpp -- similar improvements

    red-robby committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    2047307 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Add .clang-format to top level directory; apply to sdk, sm, bootrom

    @red-robby
    red-robby committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    b7c1625 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dev-sdk-code-quality

    @red-robby
    red-robby committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    2a02f68 View commit details
    Browse the repository at this point in the history

  3. Add .clang-format (mistake before)

    @red-robby
    red-robby committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    9abfae2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev-sdk-code-quality' of github.com:keystone-enclave/ke… 

    …ystone into dev-sdk-code-quality
    @red-robby
    red-robby committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    cc1b598 View commit details
    Browse the repository at this point in the history

  5. Apply .clang-format to C files in sdk (only cpp files previously)

    @red-robby
    red-robby committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    10ce4e4 View commit details
    Browse the repository at this point in the history

  6. Add .clang-tidy file to SDK, run with --fix-errors

    @red-robby
    red-robby committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    6cce522 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Add missing headers in SDK example test files

    @red-robby
    red-robby committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    553e106 View commit details
    Browse the repository at this point in the history

  2. Add another missing header

    @red-robby
    red-robby committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c5d68bf View commit details
    Browse the repository at this point in the history