You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces Singletons as a new feature for configuring global, editable database entries when it's not necessary to have more than one representation of the schema (aka, not a normal list).
Singletons can be useful for things like:
System Settings
Homepage Layout
Site Navigation
Before this feature, developers could write a typical schema for a list, and then using Keystone hooks limit the number of items within that list to approximate this functionality.
Unfortunately the GraphQL schema didn't reflect these constraints, and neither did the AdminUI.
This pull requests brings that functionality native to Keystone's schema configuration as a first class primitive.
Tasks
Add enforcement of the databases (where able) to ensure that the singleton list only ever has one item
Alter the graphql layer so that queries on singletons make more sense (remove querying for multiple items, remove the ‘where’ query on fetching a single item, as there will only ever be one)
Update the Admin UI - mostly subtractive changes to give a good experience for singletons where navigating items UI is removed, removing clicks
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emmatown
force-pushed
the
minimal-rename-lists-to-models
branch
from
This pull request introduces Singletons as a new feature for configuring global, editable database entries when it's not necessary to have more than one representation of the schema (aka, not a normal list).
Singletons can be useful for things like:
Before this feature, developers could write a typical schema for a list, and then using Keystone hooks limit the number of items within that list to approximate this functionality.
Unfortunately the GraphQL schema didn't reflect these constraints, and neither did the AdminUI.
This pull requests brings that functionality native to Keystone's schema configuration as a first class primitive.
Tasks