Rename .keystone/types to .keystone and add graphql export to .keystone
#7733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 112a8f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 112a8f8:
|
emmatown
changed the title
graphql export to .keystone/types.keystone/types to .keystone and add graphql export to .keystone
emmatown
force-pushed
the
graphql-ts-api-for-specific-context
branch
from
16a9f42 to
514e7bd
Compare
flexdinesh
approved these changes
Jul 25, 2022
dcousens
force-pushed
the
graphql-ts-api-for-specific-context
branch
from
011f3d7 to
3236e70
Compare
dcousens
force-pushed
the
graphql-ts-api-for-specific-context
branch
from
3236e70 to
5370579
Compare
dcousens
force-pushed
the
main
branch
2 times, most recently
from
26e4ead to
f2ca4d1
Compare
|
I don't think we want to do this at this time. That may change in the future, but for now I will close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
graphqlexport to.keystone(renamed from.keystone/typesbecause with thegraphqlexport, it is no longer just types) that is the same as thegraphqlexport from@keystone-6/corebut uses the specific generated context type for the project. This is important for #7575 since not using the specific context will be more painful but it also generally improves the experience of using graphql-ts for schema extensions and virtual fields.