master sync #10
Merged
master sync #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor ScriptRouter * refactor TagRouter * refactor AbstractConfiguratorListener * make sure parameter should not be null * correct comments * make ReferenceConfigurationListener private static * avoid dup code in init * add fixme for potential useless code * clean up useless variables * move methods into UrlUtils * make method private * reformat javadoc * avoid dup code * reformat log message * reformat log message * reformat the code * remove useless imports * remove useless code * refactor ScriptRouter * refactor TagRouter * refactor AbstractConfiguratorListener * Add comment * Fix UT * make sure parameter should not be null * correct comments * make ReferenceConfigurationListener private static * Revert demo changes * Revert code to avoid NPE in RPC wire after providers are cleared. * make ListenableRouter code thread safe * Fix UT * Remove assert check to continue with execute. * avoid dup code in init * solve compile error * add fixme for potential useless code * clean up useless variables * move methods into UrlUtils * make method private * reformat javadoc * avoid dup code * reformat log message * reformat log message * reformat the code * remove useless imports * remove useless code * code review comments from @khanimteyaz * code review from @khanimteyaz
* repalce hard coded values with constants and small refactor * style issue fixed
* movde compareTo into Configurator as a default method * adjust javado * optimize diamond * polish the code
delete useless code
* add twitter follow
* polish javadoc * git rid of template class for apollo * get rid of template class for NopDynamicConfiguration * get rid of tempate class for ZookeeperDynamicConfiguration * get rid of AbstractDynamicConfiguration * get rid of AbstractConfiguration * fix compilation error * fix compilation error * polish code
* remove @async from core framework. * refactor method name to isReturnFuture
* move dubbo xml demo into delegated dir * add demo for annotation usage, and rename dubbo-demo-api to dubbo-demo-interface * add pure api demo * enhance examples * remove useless imports * add readme for dubbo-demo
#3108) * Refactoring to replace hard coded value with constant and some code optiomization * Fixed UT failure * Added review comment by Ian and code4wt
* add config-api javadoc * add dubbo-config-api javadoc * update javadoc * add dubbo-config-api java doc
Release resource after use in ConfigParserTest
add javadoc for registry and optimize code
* code optimization * useless import * optimization
code optimization
* optimize log output * Separate logs for reconnect and close * remove reconnect exception log
* modify some log describe * use java8 lambda expression
* fix telnet trace times is always 1 * use StringUtils determine if the string is empty * Fix 3105 , make invoke command with Json string parameter without "class" key * Fix 3105 ，Keep the class key to support overloaded methods * optimize InvokerTelnetHandlerTest
* upgrade junit to junit5 * modify test * 批量修改upgrade_junt_to_junit5 * 删除多余的文件 * fi test case * Disabled soem test case temporarily * upgrade junit to junit5 and batch modify test case * copy some code from jupiter5.4.0.M1 for some issues * 修改rat福泽 * update rat path * revert case * add junit-platform-surefire-provider to maven-surefire-plugin * update dependency * fix coverage issue (#1) * use jupiter 5.4.0-M1 and remove junit5 source code
…backService method issue. (#3199) * Optimize the code: fix url to null, NullPointerException, change private variable to camel mode. * Optimize the code: exportOrUnexportCallbackService method camel mode. * Optimize the code: fix method:encodeInvocationArgument private callbackStatus is camel writing. * Optimize the code: fix name issue * Exporter is a noun, we should use a verb here, like Export. * The generics that can be inferred automatically are also deleted.
* refactor telnet invoke command * add select command for telnet * fix test case
* wrong event setting * modify event seeting * modify
* Code optimization, call the util method * mofidy * modify * * import package
* qos heart question fix #3165 * modify * judge if it's a IdleStateEvent * add UT * modify
* modify some typos * fix some other addionalParameterKeys and paramter typos
* must shutdown thread pool when no in use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.