Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OldTwitter support #239

Merged
merged 5 commits into from
Mar 13, 2024
Merged

feat: add OldTwitter support #239

merged 5 commits into from
Mar 13, 2024

Conversation

MeguminSama
Copy link
Contributor

@MeguminSama MeguminSama commented Mar 12, 2024

This PR adds support for OldTwitter, and resolves #185

Support for this was added in dimdenGD/OldTwitter#703 (auth fix in dimdenGD/OldTwitter#704)

Changelog

  • Added an event listener to shared.ts that listens for OLDTWITTER_REQUEST_LOAD requests
  • This then emits blue-blocker-events containing the OldTwitter request information

Deployment Checklist

  1. merge all pull requests to llb
  2. ensure src/manifest.ts and package.json have the correct version number
  3. use makefile to generate zips (make chrome, make firefox)
    • chrome should be tested with npm run build
    • test firefox locally using zip
  4. merge llb to main
  5. upload zips from 3 to chrome webstore and firefox addons

cooljeanius
cooljeanius previously approved these changes Mar 12, 2024
Copy link
Collaborator

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'm assuming you tested?

@MeguminSama
Copy link
Contributor Author

LGTM; I'm assuming you tested?

Yup! Haven't run into any issues so far :)

Copy link
Collaborator

@rougetimelord rougetimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to move this functionality into src/content/index.ts

src/shared.ts Outdated Show resolved Hide resolved
src/shared.ts Outdated Show resolved Hide resolved
@MeguminSama
Copy link
Contributor Author

MeguminSama commented Mar 13, 2024

The entire storage.sync section was unnecessary so I've removed it.

edit: would be nice if github loaded all of your comments. WIll move the code now.

@cooljeanius cooljeanius merged commit 7d74ea4 into kheina-com:main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use in combination with DimidenGD's OldTwitter extension
3 participants