-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OldTwitter support #239
feat: add OldTwitter support #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I'm assuming you tested?
Yup! Haven't run into any issues so far :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to move this functionality into src/content/index.ts
The entire storage.sync section was unnecessary so I've removed it. edit: would be nice if github loaded all of your comments. WIll move the code now. |
This PR adds support for OldTwitter, and resolves #185
Support for this was added in dimdenGD/OldTwitter#703 (auth fix in dimdenGD/OldTwitter#704)
Changelog
OLDTWITTER_REQUEST_LOAD
requestsblue-blocker-event
s containing the OldTwitter request informationDeployment Checklist
src/manifest.ts
andpackage.json
have the correct version numbermake chrome
,make firefox
)npm run build
3
to chrome webstore and firefox addons