Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of female FNR #2

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix generation of female FNR #2

merged 1 commit into from
Oct 18, 2023

Conversation

terjew
Copy link

@terjew terjew commented Oct 17, 2023

I found and fixed an issue with generation of female FNRs. The adjustment to odd seeds for male was working correctly, but the adjustment to even seeds for female was missing.

@terjew
Copy link
Author

terjew commented Oct 18, 2023

By the way, the bug also causes the non-specific generation of ids to be heavily weighted towards generating males, due to the way it is setup. When asking for a non-specified gender, the generator specifies it using Random.NextGender() which means it will also hit the buggy codepath. The net result is that around 75% of the ids generated will be male, rather than the expected 50%.

@khellang khellang merged commit ef96770 into khellang:main Oct 18, 2023
1 check passed
@khellang
Copy link
Owner

Tusen takk! 🙏🏻 Kult at noen andre også bruker biblioteket 😁 v1.2.3 ligger i indekseringskøen hos NuGet

@terjew
Copy link
Author

terjew commented Oct 19, 2023

Herlig! Takk for kjapp respons 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants