Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Menu Upgrades and Minor UX Improvements #869

Merged
merged 120 commits into from
Jul 27, 2024
Merged

Nav Menu Upgrades and Minor UX Improvements #869

merged 120 commits into from
Jul 27, 2024

Conversation

MythicalCow
Copy link
Contributor

@MythicalCow MythicalCow commented Jul 25, 2024 •
edited
Loading

Change List 🔨

  • Converted navigation menu into a dropdown menu
  • Moved collapsed side panel menu icons into top row
  • Auto refresh when conversation is deleted to update side panel and route back to main page if deletion is on current conversation
  • Highlight the current conversation in the side panel
  • Dynamic homepage messages with current day and time of day.
  • colorutils upgraded to have more expansive tailwind color options and dynamic class name generation.
  • Converted create agent button alert into shadcn ToolTip
  • Colored lines and icons for agents in chat window
  • Cleaned up border styling in dark mode
  • fixed three dot menu in side panel to be more easier to click

Image 🖼️

image

Feedback 🤝

  • Design comments
  • Flow between pages
  • Bugs and edge case testing

sabaimran and others added 30 commits July 13, 2024 00:34
@sabaimran
V1 of the new automations page
8ba79fc 
Implemented:
- Shareable
- Editable
- Suggested Cards
- Create new cards
@sabaimran
Improve notice of which email address is being delivered to
05bf911
@sabaimran
Fix validation bugs in the edit form
a8d4b8f
@sabaimran
Remove console logs for debugging
ce99c48
@sabaimran
Fix spacing in page css
9c553b9
@sabaimran
Fix spaving in nav menu
eaab311
@sabaimran
Remove syntax import for highlight.js in code
a830839
@sabaimran
Manually insert preferred styling for light/dark mode from highlight.…
0213848 
…js package
@sabaimran
Fix copy button rendering issue (it disappears if you've hovered on t…
6ea3746 
…he chat message
@sabaimran
Fix some linting errors with unescaped characters on the automations …
f3c5deb 
…page
@sabaimran
Add an alert pane showing the email, location for automations
eaf924e
@sabaimran
Merge branch 'features/chat-ui-updates-big' of github.com:khoj-ai/kho…
201a5d7 
…j into features/update-automations-page
@sabaimran
Add more icons and add a left bar for styling on each individual auto…
05b616d 
…mations card
@sabaimran
Add support for setting color and icons on the agents in the backend
ccbfc4a
@sabaimran
Migrate agents page to use the new shadcn component library and the c…
07ead01 
…olors/icons
@sabaimran
Update styling of cards
4f7fe3e
@sabaimran
Fix dark/light mode toggle rendering bug
2e43c2e
@sabaimran
Remove dead styling
a22c1da
@sabaimran
Navigate nav urls within same page, add an info piece to the agents page
d2afe26
@sabaimran
Merge branch 'features/big-upgrade-chat-ux' of github.com:khoj-ai/kho…
4243419 
…j into features/update-automations-page
@sabaimran
Merge branch 'features/big-upgrade-chat-ux' of github.com:khoj-ai/kho…
a69e3e3 
…j into features/agents-update-full
@sabaimran
Revert packages removed in merging
c976315
@sabaimran
Merge branch 'features/big-upgrade-chat-ux' of github.com:khoj-ai/kho…
a771c6f 
…j into features/update-automations-page
@sabaimran
Merge branch 'features/update-automations-page' of github.com:khoj-ai…
9288fb1 
…/khoj into features/agents-update-full
@sabaimran
simplify conditional with ternary operator
ccc145c
@sabaimran
Merge branch 'features/big-upgrade-chat-ux' of github.com:khoj-ai/kho…
7945471 
…j into features/agents-update-full
@MythicalCow
rough draft of khoj homepage finished!
3de92b0
@MythicalCow
Merge remote-tracking branch 'upstream/features/big-upgrade-chat-ux' …
a5f91a9 
…into homescreen-ui
@MythicalCow
UI completed and ready for review. working on mechanics
da11415
@MythicalCow
bugs on some things
ca2b430
@MythicalCow MythicalCow requested a review from sabaimran July 25, 2024 21:36
@MythicalCow MythicalCow added the upgrade New feature or request label Jul 25, 2024
debanjum
debanjum reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@debanjum debanjum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested or done a proper review. Left some minor comments but otherwise looks good to me

src/interface/web/yarn.lock Outdated Show resolved Hide resolved
src/interface/web/app/components/navMenu/navMenu.tsx Outdated Show resolved Hide resolved
src/interface/web/app/components/navMenu/navMenu.tsx Outdated Show resolved Hide resolved
src/interface/web/app/agents/layout.tsx Outdated Show resolved Hide resolved
src/interface/web/app/agents/page.tsx Outdated Show resolved Hide resolved
src/interface/web/app/agents/page.tsx Outdated Show resolved Hide resolved
src/interface/web/app/common/colorUtils.ts Outdated Show resolved Hide resolved
src/interface/web/app/agents/page.tsx Outdated Show resolved Hide resolved
src/interface/web/app/agents/page.tsx Outdated Show resolved Hide resolved
MythicalCow and others added 18 commits July 26, 2024 14:06
@MythicalCow
colored icons for chat
8beb90f
@MythicalCow
Merge branch 'nav-upgrades' of https://github.com/MythicalCow/khoj in…
46e78b3 
…to nav-upgrades
@MythicalCow
color coded side bands based on selected agent in conversation
c0ea9d5
@MythicalCow
dark mode white border removal
743df3e
@MythicalCow
fixed issue with three dot menu in side panel
a88666f
@sabaimran
Replace the khoj logo svg with a component that loads color dynamically
7bdbd55
@sabaimran
Update primary color to an orange base, rather than blue/purple
cbf6e31
@sabaimran
Import new khoj logo in chat history side panel
4cf183a
@sabaimran
Improve loading state and mobile rendering in the automations view
9081da4
@sabaimran
Add the KhojLogo import in the nav menu and use a default user profil…
0d20a42 
…e icon when not authenticated
@sabaimran
Get rid of custom --box-shadow CSS variable
b5fc1a1
@sabaimran
Pass the agent metadat through the chat body data in order to style t…
abb2eb0 
…he send button
@sabaimran
Add login to the unauthenticated login view, redirecto to home if con…
b3e4823 
…versation history not loaded
@sabaimran
Set a max height for the input text area
71f6fc9
@sabaimran
Merge branch 'features/big-upgrade-chat-ux' of github.com:khoj-ai/kho…
9cefc34 
…j into nav-upgrades
@sabaimran
Simplify tailwind class names
73ce239
@sabaimran
Fresh yarn.lock file
cc5f1a1
@sabaimran
Remove the userprofilecomponent from the side panel
1c503f5
sabaimran
sabaimran approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@sabaimran sabaimran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! with this set of changes it's all coming together. 🫶🏾

@sabaimran sabaimran merged commit 1685c60 into khoj-ai:features/big-upgrade-chat-ux Jul 27, 2024
5 checks passed
@debanjum debanjum mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debanjum debanjum debanjum left review comments

@sabaimran sabaimran sabaimran approved these changes

Assignees
No one assigned
Labels
upgrade New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MythicalCow @debanjum @sabaimran