Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring UI: Modernize UX for normie development #878

Merged
merged 213 commits into from
Aug 5, 2024

Conversation

sabaimran
Copy link
Member

@sabaimran sabaimran commented Aug 4, 2024

Overview

  • Update Web app to new UI/UX using React, Tailwind, Next.js, Shadcn, Phosphor Icons
    • Create Chat, Home, Settings, Automations, Search, Agents pages within the new designs, UX stack
  • Align to modern UX development principles. Design pages from a use-case based standpoint
  • Make all new pages mobile, dark-mode friendly

Details

sabaimran and others added 30 commits July 2, 2024 11:18
- Add non-functional UI elements for chat, references, feedback buttons, rename/share session, mic, attachment, websocket connection
… from URL manually. See vercel/next.js#64660 for limitations with static export / dynamic routes
Add spacing between chat message paragraphs
debanjum and others added 15 commits August 4, 2024 04:43
Previously between 00:00 - 04:00 it'd trigger afternoon insteead of
evening
Installing Khoj as PWA was supported in previous web UX as well. This
just adds link to the existing webmanifest to continue support for
installing Khoj as PWA with new web UX
- Create better styling for the input area buttons, resizing in mobile and creating more even height with a more minimal send button
- Remove x axis footer padding on small screens to preserve space,
  keep equal spacing between footer items
- Add 1rem margin to buttons to not have overlap in boundary
- Add 1rem y-axis padding to chat footer to not have focus boundary
  leave the footer boundary on smaller screens
- Remove invalid call to styles.main
- Remove unnecessary top padding above side pane to keep side pane at
  consistent position across web app
- Use same pageLayout styles and styling structure on agent like
  automation
- Vertically center automation section and page title on it's row
- Fix applying flex vs grid with tailwind
Utilize chat footer space more efficiently. This is especially useful
on small screens

- Send button is anyway only enabled when there is text in chat input
- Otherwise voice message button is better to show by default
@sabaimran sabaimran added the upgrade New feature or request label Aug 4, 2024
Copy link

gitguardian bot commented Aug 4, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10005301 Triggered Generic Password bf4c2f2 src/khoj/app/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@debanjum debanjum force-pushed the features/big-upgrade-chat-ux branch from d51022d to 40b7568 Compare August 4, 2024 23:22
Add org, markdown, pdf, word, icon and default file icons to simplify
identifying file type used as reference for generating chat response
Hierarchical documents like org-mode, markdown have their ancestry
shown in first line. Remove it to show cleaner, deduplicated reference
text from org-mode, markdown files
@debanjum debanjum force-pushed the features/big-upgrade-chat-ux branch from 40b7568 to e296d38 Compare August 4, 2024 23:30
@sabaimran sabaimran merged commit 8bc28fb into master Aug 5, 2024
15 checks passed
@sabaimran sabaimran deleted the features/big-upgrade-chat-ux branch August 5, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants