Create Settings Page in new Web App #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabaimran
requested changes
Jul 30, 2024
- Include side pane but with only the account info in it - Replicate styling of the old config page
- Update references in new and old web client settings - Arrange new client settings props and add header comments similar to - config response for code readability
- Ensure model name doesn't stretch or shrink dropdown width from parent card width - Ensure buttons flex wrap on smaller displays
- Remove now unnecessary button to Save in Card with dropdown - Use toast to show success, failure (not working) - Rename language to search, Move it to features section. Add icon to the card
- Add table shadcn component to use in API keys settings section - In dev mode, route requests to auth to khoj server at localhost:42110
- Replicate behavior on current settings.html page - Improve text for each subscription state to make it more informative, fun
…ction - Why Profile section and billing section looked too empty (1 card each). Combining them makes the setting page look more complete. Shows subscription options early on - Details - Made Futurist text orange - Made Unsubscribe a down button instead of cloud slash - Updated toast title to subscription - Improve Futurist trial title and description
- Rearrange DELETE content API definitions order to go from more specific to more general - Create batched file deletion DB adapter
Use a Command Dialog to allow easier filtering of files to view without having to leave the settings page
…are not being required in the indexer path
Improve placeholder text for notion API key and Whatsapp number (mention country code required)
sabaimran
reviewed
Jul 30, 2024
debanjum
force-pushed
the
create-config-pages-in-nextjs
branch
from
1549692 to
f58cff5
Compare
Do not make fetch request to server if user is not subscribed
debanjum
force-pushed
the
create-config-pages-in-nextjs
branch
from
2c76981 to
32ce564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details