-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit and finish updates for the new UX #877
Merged
sabaimran
merged 54 commits into
features/big-upgrade-chat-ux
from
features/fit-and-finish-new-ux
Aug 4, 2024
Merged
Fit and finish updates for the new UX #877
sabaimran
merged 54 commits into
features/big-upgrade-chat-ux
from
features/fit-and-finish-new-ux
Aug 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sabaimran
commented
Aug 2, 2024
- Use a more standardized navmenu pattern. In full screen mode, it's left aligned and also has the profile component fixed on the right side. In mobile mode, the side panel button, the khoj logo, and the profile component are all on one row, evenly spaced.
- Move the nav menu into the chat history side panel component, so that they both show up on one line - Update all pages to use it with the new formatting - in mobile, present the sidebar button, home button, and profile button evenly centered in the middle
- Improve styling for the side panel when not logged in
- Move the nav menu into the chat history side panel component, so that they both show up on one line - Update all pages to use it with the new formatting - in mobile, present the sidebar button, home button, and profile button evenly centered in the middle
- Improve styling for the side panel when not logged in
Style profile pircture button on nav menu - Use primary colored ring around subscribed user profile on nav menu - Use gray colored ring around non-subscribed user profile on nav menu - Use upper case initial as profile pic for user with no profile pic - Click anywhere on nav menu item to trigger action Previously the actual clickable area was smaller than the width of the nav menu item
- Left align email, location, timezone pills on small screens - Indent user enabled automations to improve delineation between sections
debanjum
force-pushed
the
features/fit-and-finish-new-ux
branch
from
August 3, 2024 01:42
bbe7491
to
d8fe677
Compare
…hoj into features/fit-and-finish-new-ux
… a dialog or a drawer
Set dynamic view height of page to 100%
- Reduce chat title size
- Show informative toast messages on copy, delete of API keys - Onle show API keys card in non anonymous mode. API keys aren't required (and is disabled on server side) in anon mode. Not showing card at all in anon mode reduces chance of unnecessary confusion
Allows tab search by looking at standard prefix. Still allows page title based identification of different Khoj chat sessions
Previously the footer's right border wasn't visible on small screens due to usage of w-full Use mr-1 on send button instead of px-1 on chat input parent to eualize chat footer buttons spacing
Previously the rename wasn't updating the chat session title. We'd have to refresh the page or side pane to get latest chat session names after rename action.
Previously between 00:00 - 04:00 it'd trigger afternoon insteead of evening
Installing Khoj as PWA was supported in previous web UX as well. This just adds link to the existing webmanifest to continue support for installing Khoj as PWA with new web UX
- Create better styling for the input area buttons, resizing in mobile and creating more even height with a more minimal send button
- Remove x axis footer padding on small screens to preserve space, keep equal spacing between footer items - Add 1rem margin to buttons to not have overlap in boundary - Add 1rem y-axis padding to chat footer to not have focus boundary leave the footer boundary on smaller screens
- Remove invalid call to styles.main - Remove unnecessary top padding above side pane to keep side pane at consistent position across web app - Use same pageLayout styles and styling structure on agent like automation - Vertically center automation section and page title on it's row - Fix applying flex vs grid with tailwind
Utilize chat footer space more efficiently. This is especially useful on small screens - Send button is anyway only enabled when there is text in chat input - Otherwise voice message button is better to show by default
debanjum
force-pushed
the
features/fit-and-finish-new-ux
branch
from
August 4, 2024 14:34
c7d729f
to
dcf810d
Compare
debanjum
force-pushed
the
features/fit-and-finish-new-ux
branch
from
August 4, 2024 15:34
dcf810d
to
b744dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.