[Application Service] Improve after-setup error message (elastic#191170)

kibanamachine · Aug 23, 2024 · 745ecfd · 745ecfd
1 parent 753f3d9
commit 745ecfd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/core/application/core-application-browser-internal/src/application_service.test.ts b/packages/core/application/core-application-browser-internal/src/application_service.test.ts
@@ -98,7 +98,9 @@ describe('#setup()', () => {
       await service.start(startDeps);
       expect(() =>
         register(Symbol(), createApp({ id: 'app1' }))
-      ).toThrowErrorMatchingInlineSnapshot(`"Applications cannot be registered after \\"setup\\""`);
+      ).toThrowErrorMatchingInlineSnapshot(
+        `"Applications cannot be registered after \\"setup\\" (attempted to register \\"app1\\")"`
+      );
     });
 
     it('allows to register an AppUpdater for the application', async () => {

diff --git a/packages/core/application/core-application-browser-internal/src/application_service.tsx b/packages/core/application/core-application-browser-internal/src/application_service.tsx
@@ -182,7 +182,9 @@ export class ApplicationService {
 
     const validateApp = (app: App<unknown>) => {
       if (this.registrationClosed) {
-        throw new Error(`Applications cannot be registered after "setup"`);
+        throw new Error(
+          `Applications cannot be registered after "setup" (attempted to register "${app.id}")`
+        );
       } else if (!applicationIdRegexp.test(app.id)) {
         throw new Error(
           `Invalid application id: it can only be composed of alphanum chars, '-' and '_'`