MBL-1739: Support Android 15 #2143
Draft
+1,819
−1,186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Android sdk 35 - Change compile and target SDK to version 35 - change tag for CircleCI from 2024.01.1 to 2024.09.1 * downgrade tag to 2024.08.1 * 2024.07.1 * update gradle version * add JDK_VERSION to executor environment * UPGRADE VERSIONS Kotlin version from 1.8.10 1.8.22 Jacoco_version from 0.8.8 to 0.8.11 compose version from 1.4.3 to 1.4.8 setted java 17 on the circle ci environment * add validate java version on circle ci pipeline * force java 17 on circle ci * fix typo * explicity install java 17 * specify jvm 17 on gradle * force assembleExternalRelease to use java 17 * Fix lint external release * change name of intent on ThreadView model Changed the name for function intent and PublishSubject intent so it be more clear to read * code more clean * fix ktlint
… enforcement (#2131) * Manage edge to edege - Created utility to manage edge to edge on different screens - fixed composable screens - fixed other screens with the utility * Manage edge to edge in all the screens - Manage edge to edge behavior for all the screens - modify solution * Fix last screens * Fix ktlint tests * fix KTLint
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
============================================
- Coverage 68.88% 68.76% -0.13%
Complexity 2224 2224
============================================
Files 365 366 +1
Lines 22794 22847 +53
Branches 3262 3261 -1
============================================
+ Hits 15701 15710 +9
- Misses 5320 5364 +44
Partials 1773 1773 ☔ View full report in Codecov by Sentry. |
|
fyi @jlplks add to the title of the PR the Jira Epic ticket, and in the what/why sections you can link the spike -> https://kickstarter.atlassian.net/wiki/spaces/NT/pages/3075538945/Android+15+Spike |
Arkariang
previously approved these changes
Oct 29, 2024
…2159) * Fix pledge_container UI height bug on android 15 * fix ktlint * set fitsSystemWindows to false on AppBarLayout on activity_proyect_page * set fitsystemwinfows false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Spike for the task
🤔 Why
Some changes are needed for the release of android 15 like handling edge to edge