Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT-1210] Present Project modal fullscreen on iPad #1191

Merged
merged 1 commit into from
May 13, 2020
Merged

[NT-1210] Present Project modal fullscreen on iPad #1191

merged 1 commit into from
May 13, 2020

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented May 11, 2020 •
edited by cdolm92
Loading

📲 What

Presents the project page modal fullscreen on iPad.

🤔 Why

This was a request from our iPad users.

🛠 How

Updates each place that we present ProjectNavigatorViewController to have a fullScreen modalPresentationStyle.

👀 See

Before 🐛 After 🦋

✅ Acceptance criteria

Project modals are presented fullscreen on iPad in all of the following places while iPhone presentation remains unchanged:

  • Activities
  • Discovery
  • Curated Projects
  • Dashboard
  • Messages
  • Project Activities
  • Search
  • Thanks
  • Updates

@justinswart justinswart requested review from ifbarrera and cdolm92 May 11, 2020 23:57
@justinswart justinswart merged commit e4e7bd7 into master May 13, 2020
@justinswart justinswart deleted the NT-1210-present-fullscreen-ipad branch May 13, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdolm92 cdolm92 cdolm92 approved these changes

@ifbarrera ifbarrera Awaiting requested review from ifbarrera

Assignees

@cdolm92 cdolm92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinswart @cdolm92