Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1210] Present Project modal fullscreen on iPad #1191

Merged
merged 1 commit into from
May 13, 2020
Merged

[NT-1210] Present Project modal fullscreen on iPad #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/ActivitiesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,9 @@ internal final class ActivitiesViewController: UITableViewController {

fileprivate func present(project: Project, refTag: RefTag) {
let vc = ProjectNavigatorViewController.configuredWith(project: project, refTag: refTag)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/BackerDashboardProjectsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ internal final class BackerDashboardProjectsViewController: UITableViewControlle
initialPlaylist: initialPlaylist,
navigatorDelegate: self
)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
4 changes: 3 additions & 1 deletion Kickstarter-iOS/Views/Controllers/CuratedProjectsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ final class CuratedProjectsViewController: UIViewController {
initialPlaylist: projects,
navigatorDelegate: self
)

if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}
}
Expand Down
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/DashboardViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ internal final class DashboardViewController: UITableViewController {

private func goToProject(_ project: Project, refTag: RefTag) {
let vc = ProjectNavigatorViewController.configuredWith(project: project, refTag: refTag)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
6 changes: 6 additions & 0 deletions Kickstarter-iOS/Views/Controllers/DiscoveryPageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,9 @@ internal final class DiscoveryPageViewController: UITableViewController {

fileprivate func goTo(project: Project, refTag: RefTag) {
let vc = ProjectNavigatorViewController.configuredWith(project: project, refTag: refTag)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand All @@ -432,6 +435,9 @@ internal final class DiscoveryPageViewController: UITableViewController {
initialPlaylist: initialPlaylist,
navigatorDelegate: self
)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/MessagesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ internal final class MessagesViewController: UITableViewController {

fileprivate func goTo(project: Project, refTag: RefTag) {
let vc = ProjectNavigatorViewController.configuredWith(project: project, refTag: refTag)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/ProjectActivitiesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ internal final class ProjectActivitiesViewController: UITableViewController {

internal func goToProject(project: Project) {
let vc = ProjectNavigatorViewController.configuredWith(project: project, refTag: .dashboardActivity)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/SearchViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ internal final class SearchViewController: UITableViewController {
initialPlaylist: projects,
navigatorDelegate: self
)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/ThanksViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,9 @@ internal final class ThanksViewController: UIViewController, UITableViewDelegate
initialPlaylist: projects,
navigatorDelegate: self
)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down
3 changes: 3 additions & 0 deletions Kickstarter-iOS/Views/Controllers/UpdateViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ internal final class UpdateViewController: WebViewController {

fileprivate func goTo(project: Project, refTag: RefTag) {
let vc = ProjectNavigatorViewController.configuredWith(project: project, refTag: refTag)
if UIDevice.current.userInterfaceIdiom == .pad {
vc.modalPresentationStyle = .fullScreen
}
self.present(vc, animated: true, completion: nil)
}

Expand Down