Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1270] Creator Pledge Info Navigation Bugfix #1227

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

justinswart
Copy link
Contributor

📲 What

Fixes a bug that was preventing creators from being able to navigate to pledge info from comment and backing activity cells.

🤔 Why

These regressions were introduced when we deprecated BackingViewController, these were two navigation paths that we hadn't discovered for a creator to navigate to a view a pledge.

🛠 How

  • When navigating from a comment cell we make a quick network call to fetch the Backing from the v1 API and then pass its Project and Backing IDs to ManagePledgeViewController.
    • Note we are doing this as an interim solution with the given time constraints, there is no error handling on this request and it will seemingly do nothing if it fails.
  • This PR also removes BackingViewModel and BackingViewModelTests which should have been removed along with BackingViewController. I'm pretty sure they were 🤔, perhaps a bad merge reintroduced these.

✅ Acceptance criteria

Log in as therealnativesquad, navigate to the creator dashboard, tap through to activities on a project.

  • Tap Pledge info on a pledge activity cell, this should navigate to ManagePledgeViewController.
  • Tap Pledge info on a comment activity cell, this should navigate to ManagePledgeViewController.

@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link
Contributor

@jgsamudio jgsamudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@justinswart justinswart merged commit 9118060 into master Jun 17, 2020
@justinswart justinswart deleted the NT-1270-backing-navigation-fix branch June 17, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants