Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1270] Creator Pledge Info Navigation Bugfix #1227

Merged
merged 2 commits into from
Jun 17, 2020
Merged

[NT-1270] Creator Pledge Info Navigation Bugfix #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd2319
Fetch backing before navigating to comment pledge
justinswart Jun 16, 2020
217430c
Remove unused files
justinswart Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Kickstarter-iOS/Views/Cells/ProjectActivityBackingCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Prelude_UIKit
import UIKit

internal protocol ProjectActivityBackingCellDelegate: AnyObject {
func projectActivityBackingCellGoToBacking(project: Project, user: User)
func projectActivityBackingCellGoToBacking(project: Project, backing: Backing)
func projectActivityBackingCellGoToSendMessage(project: Project, backing: Backing)
}

Expand Down Expand Up @@ -68,8 +68,8 @@ internal final class ProjectActivityBackingCell: UITableViewCell, ValueCell {

self.viewModel.outputs.notifyDelegateGoToBacking
.observeForUI()
.observeValues { [weak self] project, user in
self?.delegate?.projectActivityBackingCellGoToBacking(project: project, user: user)
.observeValues { [weak self] project, backing in
self?.delegate?.projectActivityBackingCellGoToBacking(project: project, backing: backing)
}

self.viewModel.outputs.notifyDelegateGoToSendMessage
Expand Down
4 changes: 2 additions & 2 deletions Kickstarter-iOS/Views/Controllers/ProjectActivitiesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ extension ProjectActivitiesViewController: MessageDialogViewControllerDelegate {
}

extension ProjectActivitiesViewController: ProjectActivityBackingCellDelegate {
internal func projectActivityBackingCellGoToBacking(project: Project, user: User) {
self.viewModel.inputs.projectActivityBackingCellGoToBacking(project: project, user: user)
internal func projectActivityBackingCellGoToBacking(project: Project, backing: Backing) {
self.viewModel.inputs.projectActivityBackingCellGoToBacking(project: project, backing: backing)
}

internal func projectActivityBackingCellGoToSendMessage(project: Project, backing: Backing) {
Expand Down
10 changes: 0 additions & 10 deletions Kickstarter.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,6 @@
809F8B661D08B4FF005BADD9 /* UpdateDraftViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 809F8B651D08B4FF005BADD9 /* UpdateDraftViewModel.swift */; };
80D73AF61D50F1A60099231F /* Navigation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 80E26A121D500C6A007B3022 /* Navigation.swift */; };
80E8EAC81D3EC65A007BDA4B /* Image.swift in Sources */ = {isa = PBXBuildFile; fileRef = 80E8EAC71D3EC65A007BDA4B /* Image.swift */; };
80EAEF001D243A7A008C2353 /* BackingViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 80EAEEFF1D243A7A008C2353 /* BackingViewModel.swift */; };
80EAEF051D243C4E008C2353 /* Backing.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 80EAEF031D243C4E008C2353 /* Backing.storyboard */; };
8A05CB0E23DB82D3002B01EE /* CookieRefTagFunctions.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8A05CB0D23DB82D3002B01EE /* CookieRefTagFunctions.swift */; };
8A072D3A230223B200BA1538 /* UIImage+Color.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8A072D39230223B200BA1538 /* UIImage+Color.swift */; };
Expand Down Expand Up @@ -710,7 +709,6 @@
A7ED1FBC1E831C5C00BFFA01 /* FindFriendsFriendFollowCellViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7ED1F601E831C5C00BFFA01 /* FindFriendsFriendFollowCellViewModelTests.swift */; };
A7ED1FBE1E831C5C00BFFA01 /* ProjectNotificationCellViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7ED1F621E831C5C00BFFA01 /* ProjectNotificationCellViewModelTests.swift */; };
A7ED1FBF1E831C5C00BFFA01 /* SortPagerViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7ED1F631E831C5C00BFFA01 /* SortPagerViewModelTests.swift */; };
A7ED1FC01E831C5C00BFFA01 /* BackingViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7ED1F641E831C5C00BFFA01 /* BackingViewModelTests.swift */; };
A7ED1FC21E831C5C00BFFA01 /* CommentCellViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7ED1F661E831C5C00BFFA01 /* CommentCellViewModelTests.swift */; };
A7ED1FC31E831C5C00BFFA01 /* ProfileViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7ED1F671E831C5C00BFFA01 /* ProfileViewModelTests.swift */; };
A7ED1FC41E831C5C00BFFA01 /* ProjectActivitySuccessCellViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7ED1F681E831C5C00BFFA01 /* ProjectActivitySuccessCellViewModelTests.swift */; };
Expand Down Expand Up @@ -1864,7 +1862,6 @@
80AB97B61D6281D60051C9D1 /* Debug.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = Debug.entitlements; sourceTree = "<group>"; };
80E26A121D500C6A007B3022 /* Navigation.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Navigation.swift; sourceTree = "<group>"; };
80E8EAC71D3EC65A007BDA4B /* Image.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Image.swift; sourceTree = "<group>"; };
80EAEEFF1D243A7A008C2353 /* BackingViewModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BackingViewModel.swift; sourceTree = "<group>"; };
80EAEF031D243C4E008C2353 /* Backing.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; path = Backing.storyboard; sourceTree = "<group>"; };
8A05CB0D23DB82D3002B01EE /* CookieRefTagFunctions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CookieRefTagFunctions.swift; sourceTree = "<group>"; };
8A072D39230223B200BA1538 /* UIImage+Color.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIImage+Color.swift"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -2213,7 +2210,6 @@
A7ED1F601E831C5C00BFFA01 /* FindFriendsFriendFollowCellViewModelTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FindFriendsFriendFollowCellViewModelTests.swift; sourceTree = "<group>"; };
A7ED1F621E831C5C00BFFA01 /* ProjectNotificationCellViewModelTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ProjectNotificationCellViewModelTests.swift; sourceTree = "<group>"; };
A7ED1F631E831C5C00BFFA01 /* SortPagerViewModelTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SortPagerViewModelTests.swift; sourceTree = "<group>"; };
A7ED1F641E831C5C00BFFA01 /* BackingViewModelTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BackingViewModelTests.swift; sourceTree = "<group>"; };
A7ED1F661E831C5C00BFFA01 /* CommentCellViewModelTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CommentCellViewModelTests.swift; sourceTree = "<group>"; };
A7ED1F671E831C5C00BFFA01 /* ProfileViewModelTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ProfileViewModelTests.swift; sourceTree = "<group>"; };
A7ED1F681E831C5C00BFFA01 /* ProjectActivitySuccessCellViewModelTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ProjectActivitySuccessCellViewModelTests.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -3432,7 +3428,6 @@
77C9122823C4FC0B00F3D2C9 /* ApplePayCapabilities.swift */,
77C9122E23C508CF00F3D2C9 /* ApplePayCapabilitiesTests.swift */,
A7C725791C85D36D005A016B /* AssetImageGeneratorType.swift */,
8AF3EBD32466134A007598BF /* Backing+PledgeAmount.swift */,
374CB94E22C17D4E00B84219 /* CharacterSet.swift */,
374CB95022C17D6700B84219 /* CharacterSetTests.swift */,
A7FC8C051C8F1DEA00C3B49B /* CircleAvatarImageView.swift */,
Expand Down Expand Up @@ -3576,7 +3571,6 @@
A7ED1F251E830FDC00BFFA01 /* UILabel+SimpleHTMLTests.swift */,
D0D77C1D22D3FC3400356FEA /* UIPageViewController+ThreadSafety.swift */,
A7C725991C85D36D005A016B /* UIPress-Extensions.swift */,
8A6C58922475E5950098D5A2 /* UIRefreshControl+StartRefreshing.swift */,
A78537E11CB5422100385B73 /* UIScreenType.swift */,
A7169BF51DDD064200480C0D /* UIScrollView+Extensions.swift */,
37FDAF702273B7FF00662CC8 /* UIStackView.swift */,
Expand Down Expand Up @@ -3841,8 +3835,6 @@
A7A626171E85B936004C931A /* BackerDashboardViewModelTests.swift */,
A7F441931D005A9400FE6FC5 /* BackingCellViewModel.swift */,
A7ED1F5C1E831C5C00BFFA01 /* BackingCellViewModelTests.swift */,
80EAEEFF1D243A7A008C2353 /* BackingViewModel.swift */,
A7ED1F641E831C5C00BFFA01 /* BackingViewModelTests.swift */,
D04AAC12218BB70A00CF713E /* BetaToolsViewModel.swift */,
D04AAC1A218BB70B00CF713E /* BetaToolsViewModelTests.swift */,
771E6308234258D1005967E8 /* CancelPledgeViewModel.swift */,
Expand Down Expand Up @@ -5170,7 +5162,6 @@
A7F441AF1D005A9400FE6FC5 /* ActivityFriendBackingViewModel.swift in Sources */,
8AAA9BD822F49EC200F12976 /* UIColor+Mixing.swift in Sources */,
D04AAC34218BB70D00CF713E /* SettingsAccountPickerCellViewModel.swift in Sources */,
80EAEF001D243A7A008C2353 /* BackingViewModel.swift in Sources */,
A75511691C8642C3005355CF /* UILabel+IBClear.swift in Sources */,
77319C822469FE9F0051B755 /* DiscoveryProjectTagPillViewModel.swift in Sources */,
A7F441E51D005A9400FE6FC5 /* SearchViewModel.swift in Sources */,
Expand Down Expand Up @@ -5405,7 +5396,6 @@
D72370542118C19B001EA4CA /* SettingsRecommendationsCellViewModelTests.swift in Sources */,
A7ED1FCC1E831C5C00BFFA01 /* ProjectActivityBackingCellViewModelTests.swift in Sources */,
A7ED1FED1E831C5C00BFFA01 /* DashboardProjectsDrawerCellViewModelTests.swift in Sources */,
A7ED1FC01E831C5C00BFFA01 /* BackingViewModelTests.swift in Sources */,
A7ED1FE01E831C5C00BFFA01 /* DiscoveryNavigationHeaderViewModelTests.swift in Sources */,
A7ED1F481E831BA200BFFA01 /* AlertError+Equatable.swift in Sources */,
7720BA7022E0DBD10071FDA1 /* InstantiableTests.swift in Sources */,
Expand Down
Loading