Migrate org-gcal to aio #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hope it's OK to ask but, what's stopping you from removing the duplicate function names and merging this into |
|
There were a few minor issues I didn't have the time to work out. If you
want to try it out feel free to.
…On Sun, Jan 30, 2022, 10:20 Adrià Garriga-Alonso ***@***.***> wrote:
Hope it's OK to ask but, what's stopping you from removing the duplicate
function names and merging this into master? Any remaining bugs to squash?
—
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANMVDNLYUV6IJMTRQSG7XDUYV6QHANCNFSM5CIJMYBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I recently pushed some updates to this branch to incorporate more recent
updates. If you want to take a look at this, feel free.
…On Sun, Jan 30, 2022 at 2:21 PM Robert Irelan ***@***.***> wrote:
There were a few minor issues I didn't have the time to work out. If you
want to try it out feel free to.
On Sun, Jan 30, 2022, 10:20 Adrià Garriga-Alonso ***@***.***>
wrote:
> Hope it's OK to ask but, what's stopping you from removing the duplicate
> function names and merging this into master? Any remaining bugs to
> squash?
>
> —
> Reply to this email directly, view it on GitHub
> <#160 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AANMVDNLYUV6IJMTRQSG7XDUYV6QHANCNFSM5CIJMYBQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
Robert Irelan
***@***.***
|
telotortium
force-pushed
the
aio
branch
2 times, most recently
from
649ebb2
to
8850fdf
Compare
telotortium
force-pushed
the
aio
branch
2 times, most recently
from
4e187da
to
6fc8d32
Compare
telotortium
force-pushed
the
aio
branch
2 times, most recently
from
74b4833
to
7815d9e
Compare
There are still some bugs I need to work out.
This requires listening for the `aio-cancel` signal in an `aio-listen` callback and calling `request-abort`.
Upstream: https://github.com/telotortium/emacs-aio-iter2/blob/5b0a9f81ed5bddc60f252b4f46924887190d91af/aio-iter2.el Otherwise, MELPA will fail to load this file. I'm done with development of aio-iter2, I'm pretty sure.
`org-gcal-test--post-at-point-aio-basic` mostly works as intended, except that the `let` bindings don't function as intended - not sure why.
It appears that this keyword doesn't work for this. I don't know if there's a way to make it work, or I'll just need to write a wrapper interactive function around the AIO functions.
Follow [Multi-file Packages](https://www.gnu.org/software/emacs/manual/html_node/elisp/Multi_002dfile-Packages.html) in Emacs Lisp Manual, inspired by [magit-pkg.el](https://github.com/magit/magit/blob/b32521d5432b5fbc33a2e47b72f2258bf98cb8b4/lisp/magit-pkg.el). Needed because Cask wasn't picking up the `iter2` dependency of `aio-iter2` - this is an indirect dependency of `org-gcal.el`, but wasn't included in the `Package-Requires` line before. Since we use multiple Emacs Lisp files, it's best to acknowledge that explicitly.
This won't be directly used, but I'd like to break out this file into a separate package someday.
Figured out right way to do it.
- Allow testing only a subset of tests using `TEST_PATTERN`. - It appears some tests occasionally fail if run all in the same Emacs, but work if they are run separately. So, if I find failed tests, I rerun each failing test individually to see which ones actually fail.
Useful for writing test servers to test code using a real HTTP server instead of mocks.
Will be needed for main code and tests.
Now it seems like this work interactively, and working on tests.
Ensure package remains clean with respect to checkdoc.
Improves the speed of modifying buffers when many updates are being done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #159