Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Genomic Workflow Output Manifest #494

Merged
merged 5 commits into from
Oct 27, 2020

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented Oct 22, 2020

Closes #492

@znatty22 znatty22 added the feature New functionality label Oct 22, 2020
@znatty22 znatty22 self-assigned this Oct 22, 2020
@dankolbman
Copy link
Contributor

Can you name your migration with the -n flag?

@dankolbman dankolbman self-requested a review October 26, 2020 14:44
'workflow_type',
'source_read'
],
"template": "genomic_workflow_output_config.py",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make this template or else we may hit bugs when we try to return an extract config for this file type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will add

@znatty22 znatty22 force-pushed the gen-workflow-output-doc-type branch 2 times, most recently from c2d3f33 to b1c0d15 Compare October 26, 2020 19:46
@znatty22 znatty22 changed the title ✨ Add Genomic Workflow Output Manifest file type ✨ Add Genomic Workflow Output Manifest Oct 26, 2020
@znatty22 znatty22 marked this pull request as ready for review October 26, 2020 21:20
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #494 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files          74       74           
  Lines        3400     3401    +1     
=======================================
+ Hits         3118     3119    +1     
  Misses        282      282           
Impacted Files Coverage Δ
creator/analyses/file_types.py 100.00% <ø> (ø)
creator/files/models.py 97.03% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc60fd...d5fbe6c. Read the comment docs.

Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕊

@znatty22 znatty22 merged commit a9101a9 into master Oct 27, 2020
@znatty22 znatty22 deleted the gen-workflow-output-doc-type branch October 27, 2020 19:21
dankolbman added a commit that referenced this pull request Nov 4, 2020
## Release 1.14.6

### Summary

- Emojis: ✨ x2
- Categories: Additions x2

### New features and changes

- [#494](#494) - ✨ Add Genomic Workflow Output Manifest - [a9101a9](a9101a9) by [znatty22](https://github.com/znatty22)
- [#482](#482) - ✨ Job logs - [2bc60fd](2bc60fd) by [dankolbman](https://github.com/dankolbman)
@dankolbman dankolbman mentioned this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New expedited document type for genomic workflow output data
2 participants