Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Initial DataReview GraphQL API #574

Merged
merged 5 commits into from
Feb 26, 2021
Merged

✨ Initial DataReview GraphQL API #574

merged 5 commits into from
Feb 26, 2021

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented Feb 14, 2021

Closes #548
Closes #549

data_review

@znatty22 znatty22 added the feature New functionality label Feb 14, 2021
@znatty22 znatty22 self-assigned this Feb 14, 2021
creator/data_reviews/signals.py Outdated Show resolved Hide resolved
creator/data_reviews/tasks.py Outdated Show resolved Hide resolved
@znatty22 znatty22 force-pushed the initial-data-review branch 3 times, most recently from 77e6b6b to d20b0d8 Compare February 16, 2021 21:07
creator/data_reviews/models.py Show resolved Hide resolved
creator/data_reviews/mutations.py Outdated Show resolved Hide resolved
creator/data_reviews/mutations.py Outdated Show resolved Hide resolved
creator/data_reviews/models.py Show resolved Hide resolved
creator/data_reviews/queries.py Show resolved Hide resolved
@znatty22 znatty22 force-pushed the initial-data-review branch 6 times, most recently from d7078ce to e4ee2e9 Compare February 18, 2021 14:21
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #574 (635c728) into master (40cf58c) will decrease coverage by 0.87%.
The diff coverage is 95.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
- Coverage   93.44%   92.56%   -0.88%     
==========================================
  Files          92      108      +16     
  Lines        4025     4789     +764     
==========================================
+ Hits         3761     4433     +672     
- Misses        264      356      +92     
Impacted Files Coverage Δ
creator/groups.py 100.00% <ø> (ø)
creator/data_reviews/nodes.py 88.88% <88.88%> (ø)
creator/data_reviews/signals.py 89.47% <89.47%> (ø)
creator/data_reviews/factories.py 90.47% <90.47%> (ø)
creator/data_reviews/mutations.py 95.00% <95.00%> (ø)
creator/data_reviews/__init__.py 100.00% <100.00%> (ø)
creator/data_reviews/apps.py 100.00% <100.00%> (ø)
creator/data_reviews/models.py 100.00% <100.00%> (ø)
creator/data_reviews/queries.py 100.00% <100.00%> (ø)
creator/data_reviews/schema.py 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cf58c...635c728. Read the comment docs.

@znatty22 znatty22 marked this pull request as ready for review February 18, 2021 14:35
creator/data_reviews/models.py Show resolved Hide resolved
creator/data_reviews/models.py Outdated Show resolved Hide resolved
creator/data_reviews/models.py Show resolved Hide resolved
creator/data_reviews/mutations.py Show resolved Hide resolved
creator/data_reviews/models.py Outdated Show resolved Hide resolved
@znatty22 znatty22 force-pushed the initial-data-review branch 4 times, most recently from 2e1711e to 7d99ea9 Compare February 23, 2021 00:23
creator/data_reviews/mutations.py Outdated Show resolved Hide resolved
creator/data_reviews/mutations.py Show resolved Hide resolved
creator/data_reviews/mutations.py Outdated Show resolved Hide resolved
creator/data_reviews/queries.py Show resolved Hide resolved
creator/data_reviews/queries.py Show resolved Hide resolved
creator/data_reviews/signals.py Outdated Show resolved Hide resolved
creator/data_reviews/signals.py Show resolved Hide resolved
@znatty22 znatty22 force-pushed the initial-data-review branch 3 times, most recently from d278411 to 8fb9ac1 Compare February 23, 2021 20:09
@znatty22 znatty22 force-pushed the initial-data-review branch 2 times, most recently from e654bce to 1c48676 Compare February 24, 2021 17:22
Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👺

@znatty22 znatty22 merged commit 5903cbb into master Feb 26, 2021
@znatty22 znatty22 deleted the initial-data-review branch February 26, 2021 17:13
dankolbman added a commit that referenced this pull request Feb 26, 2021
## Release 1.15.1

### Summary

- Emojis: 🐛 x1, 🔥 x1, ✨ x1
- Categories: Fixes x1, Removals x1, Additions x1

### New features and changes

- [#586](#586) - 🐛 Add missing import - [fdcd20a](fdcd20a) by [dankolbman](https://github.com/dankolbman)
- [#587](#587) - 🔥 Remove build_environments for worker - [7be9e36](7be9e36) by [dankolbman](https://github.com/dankolbman)
- [#574](#574) - ✨ Initial DataReview GraphQL API - [5903cbb](5903cbb) by [znatty22](https://github.com/znatty22)
@dankolbman dankolbman mentioned this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Review GraphQL API DataReview Model
2 participants